Bug 128077 – WebKit Bot Watcher's Dashboard: Defer subsequent resource loads from access-restricted build bot when iteration fails to load with HTTP 401 status code

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Daniel Bates]

We should only prompt for HTTP credentials once per iteration load similar to what we do when we fetch the list of iterations (bug #127849). That is, if an HTTP 401 error occurs when we load an iteration we should notify the associated Buildbot object and update the associated queue view so that we prevent subsequent load attempt for other iterations (*) and show an "unauthorized" message on the dashboard, respectively.

(*) Such attempts would trigger an authentication dialog, which can be seen as annoying.

[Daniel Bates]

Created attachment 222932 [details]
Patch

[Daniel Bates]

Created attachment 222933 [details]
Patch

Rebased patch

[Alexey Proskuryakov]

Comment on attachment 222933 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222933&action=review

> Tools/ChangeLog:12
> +        an iteration each time the update queue time fires until a person successfully authenticates. Instead
> +        we should update the authentication status of the build bot on receiving an HTTP 401 response code such
> +        that we defer subsequent requests to load the iteration when the queue update timer fires.

Isn't this too frequent? We load a lot of iterations.

[Daniel Bates]

Created attachment 222995 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 222995 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222995&action=review

> Tools/ChangeLog:12
> +        HTTP credentials for an iteration so long as an earlier authentication request wasn't cancelled
> +        (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
> +        presented for an iteration each time the update queue timer fires until a person successfully

I think that this would be easier to understand if it said "credentials for the buildbot" not "credentials for am iteration".

[Daniel Bates]

(In reply to comment #5)
> (From update of attachment 222995 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222995&action=review
> 
> > Tools/ChangeLog:12
> > +        HTTP credentials for an iteration so long as an earlier authentication request wasn't cancelled
> > +        (i.e. failed with an HTTP 401 Unauthorized status code). Currently an authentication dialog will be
> > +        presented for an iteration each time the update queue timer fires until a person successfully
> 
> I think that this would be easier to understand if it said "credentials for the buildbot" not "credentials for am iteration".

Will change before landing.

[Daniel Bates]

Committed r163314: <http://trac.webkit.org/changeset/163314>