Subpixel rendering: LayoutUnit operator++ is broken.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[zalan]

It defines post-increment only and implements it as if it was pre-increment.

[zalan]

Created attachment 222899 [details]
Patch

[Darin Adler]

Comment on attachment 222899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222899&action=review

> Source/WebCore/platform/LayoutUnit.h:197
> -    LayoutUnit operator++(int)
> +    LayoutUnit& operator++()
>      {
>          m_value += kEffectiveFixedPointDenominator;
>          return *this;
>      }

Great fix!

> Source/WebCore/platform/LayoutUnit.h:204
> +    LayoutUnit operator++(int)
> +    {
> +        LayoutUnit result = *this;
> +        ++(*this);
> +        return result;
> +    }

Not sure we really need to add this, although I suppose it does little harm.

On a separate note, if it was me I would have written ++*this without parentheses.

[zalan]

(In reply to comment #2)
> (From update of attachment 222899 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222899&action=review
> 
> > Source/WebCore/platform/LayoutUnit.h:197
> > -    LayoutUnit operator++(int)
> > +    LayoutUnit& operator++()
> >      {
> >          m_value += kEffectiveFixedPointDenominator;
> >          return *this;
> >      }
> 
> Great fix!
> 
> > Source/WebCore/platform/LayoutUnit.h:204
> > +    LayoutUnit operator++(int)
> > +    {
> > +        LayoutUnit result = *this;
> > +        ++(*this);
> > +        return result;
> > +    }
> 
> Not sure we really need to add this, although I suppose it does little harm.
Indeed! I guess we can add it back when it is actually needed. I'll land this without the post increment. Thanks!

[zalan]

Created attachment 222907 [details]
Patch

[zalan]

Comment on attachment 222907 [details]
Patch

EWS testing

[WebKit Commit Bot]

Comment on attachment 222907 [details]
Patch

Clearing flags on attachment: 222907

Committed r163260: <http://trac.webkit.org/changeset/163260>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.