Bug 128018

Summary: Expose creation and modification times for LocalStorage
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch
none
with new file added
andersca: review+
patch for landing none

Description Alexey Proskuryakov 2014-01-31 14:26:41 PST 
<rdar://problem/15642344>
Comment 1 Alexey Proskuryakov 2014-01-31 14:30:40 PST 
Created attachment 222851 [details]
proposed patch
Comment 2 Alexey Proskuryakov 2014-01-31 14:39:23 PST 
Created attachment 222854 [details]
with new file added
Comment 3 Anders Carlsson 2014-01-31 14:46:45 PST 
Comment on attachment 222854 [details]
with new file added

View in context: https://bugs.webkit.org/attachment.cgi?id=222854&action=review

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:429
> +void StorageManager::getStoragesByOrigin(FunctionDispatcher* callbackDispatcher, void* context, void (*callback)(const Vector<LocalStorageDetails>& storageDetails, void* context))

I don't think "storages" is a word. How about "storageDetails" or "storageInformation"

> Source/WebKit2/UIProcess/Storage/StorageManager.cpp:644
> +void StorageManager::getStoragesByOriginInternal(FunctionDispatcher* dispatcher, void* context, void (*callbackFunction)(const Vector<LocalStorageDetails>& storageDetails, void* context))

Same comment here.
Comment 4 Alexey Proskuryakov 2014-01-31 14:49:39 PST 
Created attachment 222856 [details]
patch for landing
Comment 5 WebKit Commit Bot 2014-01-31 15:24:02 PST 
Comment on attachment 222856 [details]
patch for landing

Clearing flags on attachment: 222856

Committed r163212: <http://trac.webkit.org/changeset/163212>
Comment 6 WebKit Commit Bot 2014-01-31 15:24:04 PST 
All reviewed patches have been landed.  Closing bug.