Bug 12801

Summary:

Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

Product:

WebKit

Reporter:

mitz

Component:

HTML Editing

Assignee:

Alexey Proskuryakov <ap>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

justin.garcia

Priority:

Version:

420+

Hardware:

Mac

OS:

OS X 10.4

Attachments:

Description	Flags
Test case (will assert when instructions are followed)	none
Non-SVG test case (ditto)	none
Look for <body> (and assert if not found) only in HTML documents	ap: review-
remove the assertion	mjs: review+

mitz

Reported 2007-02-17 23:07:28 PST

To reproduce: open the attachment w/ a debug build of TOT WebKit, choose Edit > Select All and the Edit > Copy. Actual result: ASSERTION FAILED: root (WebCore/editing/markup.cpp:397 WebCore::DeprecatedString WebCore::createMarkup(const WebCore::Range*, WTF::Vector<WebCore::Node*, 0ul>*, WebCore::EAnnotateForInterchange))

Attachments
Test case (will assert when instructions are followed) (220 bytes, image/svg+xml) 2007-02-17 23:17 PST, mitz	no flags	Details
Non-SVG test case (ditto) (72 bytes, application/xml) 2007-02-17 23:22 PST, mitz	no flags	Details
Look for <body> (and assert if not found) only in HTML documents (3.52 KB, patch) 2007-02-18 06:45 PST, mitz	ap: review-	Details Formatted Diff Diff
remove the assertion (3.39 KB, patch) 2007-02-28 11:01 PST, Alexey Proskuryakov	mjs: review+	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

mitz

Comment 1 2007-02-17 23:17:04 PST

Created attachment 13218 [details] Test case (will assert when instructions are followed)

mitz

Comment 2 2007-02-17 23:22:34 PST

Created attachment 13219 [details] Non-SVG test case (ditto)

mitz

Comment 3 2007-02-18 06:45:39 PST

Created attachment 13225 [details] Look for <body> (and assert if not found) only in HTML documents

mitz

Comment 4 2007-02-18 09:51:49 PST

Comment on attachment 13225 [details] Look for <body> (and assert if not found) only in HTML documents Based on Alexey's comments, I am going to leave this to other people who know what they're doing.

Alexey Proskuryakov

Comment 5 2007-02-18 09:53:31 PST

Comment on attachment 13225 [details] Look for <body> (and assert if not found) only in HTML documents I think it is wrong to introduce different behavior for HTML and XHTML here (since isHTMLDocument() returns false for XHML). I am not quite sure about the correct solution, but maybe one can just traverse up the hierarchy until seeing either a node that's not an HTML element, or a body.

Alexey Proskuryakov

Comment 6 2007-02-28 11:01:36 PST

Created attachment 13427 [details] remove the assertion Not that I know what I'm doing... :-)

Maciej Stachowiak

Comment 7 2007-02-28 19:42:15 PST

Comment on attachment 13427 [details] remove the assertion I think removing the assertion is probably right. r=me

Alexey Proskuryakov

Comment 8 2007-03-01 09:21:24 PST

Committed revision 19926.

Note You need to log in before you can comment on or make changes to this bug.