Bug 12800

Summary: Some COMPILER(MSVC) blocks marked instead as PLATFORM(WIN)
Product: WebKit Reporter: Kevin Ollivier <kevino>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P3    
Version: 420+   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate. aroben: review+

Kevin Ollivier
Reported 2007-02-17 20:03:39 PST
If a platform/port other than Win32 is built using MSVC on Windows (e.g. the wx port), it currently won't compile unless WTF_PLATFORM_WIN is explicitly defined. (Which doesn't seem right to me.) After changing these blocks to check for COMPILER(MSVC) instead, I am able to compile JSCore and WebCore using MSVC without defining WTF_PLATFORM_WIN.
Attachments
Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate. (2.17 KB, patch)
2007-02-17 20:04 PST, Kevin Ollivier 		aroben: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kevin Ollivier
Comment 1 2007-02-17 20:04:59 PST
Created attachment 13217 [details] Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate.
Adam Roben (:aroben)
Comment 2 2007-02-17 20:08:49 PST
Comment on attachment 13217 [details] Changes PLATFORM(WIN) to COMPILER(MSVC) where appropriate. Looks good. r=me!
Alexey Proskuryakov
Comment 3 2007-02-18 00:59:57 PST
Committed revision 19688.
Note You need to log in before you can comment on or make changes to this bug.