Bug 127975

Summary:

Subpixel rendering: Change RenderBoxModelObject's border functions' signature to support subpixel border painting.

Product:

WebKit

Reporter:

alan <zalan>

Component:

Layout and Rendering

Assignee:

alan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

127524

Attachments:

Description	Flags
Patch	none
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none
Patch	none
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion	none
Patch	none

alan

Reported 2014-01-30 17:37:45 PST

from int to LayoutUnit.

Attachments
Patch (17.27 KB, patch) 2014-01-30 17:54 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 (357.23 KB, application/zip) 2014-01-30 19:31 PST, Build Bot	no flags	Details
Patch (16.83 KB, patch) 2014-01-30 22:03 PST, alan	no flags	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (963.02 KB, application/zip) 2014-01-30 23:33 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (775.79 KB, application/zip) 2014-01-31 00:11 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-08 for mac-mountainlion (962.49 KB, application/zip) 2014-01-31 00:30 PST, Build Bot	no flags	Details
Patch (16.81 KB, patch) 2014-01-31 07:09 PST, alan	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

alan

Comment 1 2014-01-30 17:54:38 PST

Created attachment 222772 [details] Patch

alan

Comment 2 2014-01-30 17:56:40 PST

It fails on EWS because it depends on code from bug 127949

Build Bot

Comment 3 2014-01-30 19:30:59 PST

Comment on attachment 222772 [details] Patch Attachment 222772 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6453886629969920 New failing tests: compositing/geometry/abs-position-inside-opacity.html compositing/geometry/vertical-scroll-composited.html compositing/geometry/layer-due-to-layer-children.html animations/3d/state-at-end-event-transform.html compositing/direct-image-compositing.html compositing/geometry/layer-due-to-layer-children-deep.html compositing/iframes/iframe-in-composited-layer.html compositing/iframes/iframe-copy-on-scroll.html compositing/overflow/overflow-positioning.html compositing/masks/multiple-masks.html compositing/overflow/ancestor-overflow.html compositing/overflow/overflow-compositing-descendant.html compositing/layers-inside-overflow-scroll.html compositing/animation/state-at-end-event-transform-layer.html compositing/sibling-positioning.html compositing/generated-content.html compositing/self-painting-layers.html compositing/masks/simple-composited-mask.html animations/3d/change-transform-in-end-event.html compositing/geometry/video-opacity-overlay.html compositing/geometry/horizontal-scroll-composited.html compositing/geometry/limit-layer-bounds-overflow-repaint.html compositing/iframes/iframe-content-flipping.html compositing/geometry/clipping-foreground.html compositing/masks/masked-ancestor.html compositing/overflow/nested-scrolling.html compositing/geometry/partial-layout-update.html compositing/iframes/composited-iframe-alignment.html compositing/geometry/outline-change.html compositing/geometry/root-layer-update.html

Build Bot

Comment 4 2014-01-30 19:31:01 PST

Created attachment 222783 [details] Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-09 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

alan

Comment 5 2014-01-30 22:03:58 PST

Created attachment 222793 [details] Patch

Build Bot

Comment 6 2014-01-30 23:33:40 PST

Comment on attachment 222793 [details] Patch Attachment 222793 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5862326825648128 New failing tests: css2.1/t0803-c5502-mrgn-r-01-c-a.html fast/borders/border-radius-wide-border-04.html css2.1/t1001-abs-pos-cb-09-b.html fast/block/margin-collapse/015.html ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm fast/borders/borderRadiusDouble09.html css2.1/t0804-c5507-padn-r-01-c-a.html fast/block/positioning/absolute-with-html-border-strict.html fast/repaint/table-cell-collapsed-border-scroll.html fast/borders/border-radius-wide-border-01.html fast/css/pseudo-first-line-border-width.html fast/block/margin-collapse/016.html css2.1/t0803-c5504-mrgn-l-01-c-a.html fast/borders/borderRadiusDouble07.html fast/borders/borderRadiusDouble06.html fast/block/positioning/absolute-with-html-border-quirks.html css2.1/20110323/block-non-replaced-width-008.htm fast/borders/borderRadiusDouble08.html transforms/2d/transform-origin-borderbox.html fast/block/margin-collapse/block-inside-inline/015.html fast/borders/borderRadiusDashed06.html fast/borders/border-image-massive-scale.html css2.1/t1001-abs-pos-cb-07-b.html fast/block/margin-collapse/block-inside-inline/016.html fast/borders/border-image-omit-right-slice.html css2.1/t0804-c5509-padn-l-01-b-a.html fast/borders/border-radius-different-width-001.html css2.1/t1001-abs-pos-cb-08-b.html

Build Bot

Comment 7 2014-01-30 23:33:42 PST

Created attachment 222797 [details] Archive of layout-test-results from webkit-ews-02 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-02 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 8 2014-01-31 00:11:29 PST

Comment on attachment 222793 [details] Patch Attachment 222793 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6330443095867392 New failing tests: css2.1/t0803-c5502-mrgn-r-01-c-a.html fast/borders/border-radius-wide-border-04.html css2.1/t1001-abs-pos-cb-09-b.html fast/block/margin-collapse/015.html ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm fast/borders/borderRadiusDouble09.html css2.1/t0804-c5507-padn-r-01-c-a.html fast/block/positioning/absolute-with-html-border-strict.html fast/repaint/table-cell-collapsed-border-scroll.html fast/borders/border-radius-wide-border-01.html fast/css/pseudo-first-line-border-width.html fast/block/margin-collapse/016.html css2.1/t0803-c5504-mrgn-l-01-c-a.html fast/borders/borderRadiusDouble07.html fast/borders/borderRadiusDouble06.html fast/block/positioning/absolute-with-html-border-quirks.html css2.1/20110323/block-non-replaced-width-008.htm fast/borders/borderRadiusDouble08.html transforms/2d/transform-origin-borderbox.html fast/block/margin-collapse/block-inside-inline/015.html fast/borders/borderRadiusDashed06.html fast/borders/border-image-massive-scale.html css2.1/t1001-abs-pos-cb-07-b.html fast/block/margin-collapse/block-inside-inline/016.html fast/borders/border-image-omit-right-slice.html css2.1/t0804-c5509-padn-l-01-b-a.html fast/borders/border-radius-different-width-001.html css2.1/t1001-abs-pos-cb-08-b.html

Build Bot

Comment 9 2014-01-31 00:11:32 PST

Created attachment 222801 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 10 2014-01-31 00:30:28 PST

Comment on attachment 222793 [details] Patch Attachment 222793 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5522466063515648 New failing tests: css2.1/t0803-c5502-mrgn-r-01-c-a.html fast/borders/border-radius-wide-border-04.html css2.1/t1001-abs-pos-cb-09-b.html fast/block/margin-collapse/015.html ietestcenter/css3/bordersbackgrounds/border-radius-different-width-001.htm fast/borders/borderRadiusDouble09.html css2.1/t0804-c5507-padn-r-01-c-a.html fast/block/positioning/absolute-with-html-border-strict.html fast/repaint/table-cell-collapsed-border-scroll.html fast/borders/border-radius-wide-border-01.html fast/css/pseudo-first-line-border-width.html fast/block/margin-collapse/016.html css2.1/t0803-c5504-mrgn-l-01-c-a.html fast/borders/borderRadiusDouble07.html fast/borders/borderRadiusDouble06.html fast/block/positioning/absolute-with-html-border-quirks.html css2.1/20110323/block-non-replaced-width-008.htm fast/borders/borderRadiusDouble08.html transforms/2d/transform-origin-borderbox.html fast/block/margin-collapse/block-inside-inline/015.html fast/borders/borderRadiusDashed06.html fast/borders/border-image-massive-scale.html css2.1/t1001-abs-pos-cb-07-b.html fast/block/margin-collapse/block-inside-inline/016.html fast/borders/border-image-omit-right-slice.html css2.1/t0804-c5509-padn-l-01-b-a.html fast/borders/border-radius-different-width-001.html css2.1/t1001-abs-pos-cb-08-b.html

Build Bot

Comment 11 2014-01-31 00:30:31 PST

Created attachment 222803 [details] Archive of layout-test-results from webkit-ews-08 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-08 Port: mac-mountainlion Platform: Mac OS X 10.8.5

alan

Comment 12 2014-01-31 07:09:14 PST

Created attachment 222811 [details] Patch

alan

Comment 13 2014-01-31 07:09:34 PST

Comment on attachment 222811 [details] Patch EWS testing

WebKit Commit Bot

Comment 14 2014-01-31 08:44:16 PST

Comment on attachment 222811 [details] Patch Clearing flags on attachment: 222811 Committed r163171: <http://trac.webkit.org/changeset/163171>

WebKit Commit Bot

Comment 15 2014-01-31 08:44:19 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.