Bug 127952

Summary:

decidePolicyForNewWindowAction should take a NavigationActionData object

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2014-01-30 14:45:47 PST

decidePolicyForNewWindowAction should take a NavigationActionData object

Comment 1 Anders Carlsson 2014-01-30 14:46:23 PST

Created attachment 222741 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-30 14:49:16 PST

Attachment 222741 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/APIPolicyClient.h:55:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Andreas Kling 2014-01-30 14:58:18 PST

Comment on attachment 222741 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222741&action=review

> Source/WebKit2/UIProcess/API/C/WKPage.cpp:1014
> -        virtual void decidePolicyForNewWindowAction(WebPageProxy* page, WebFrameProxy* frame, NavigationType type, WebEvent::Modifiers modifiers, WebMouseEvent::Button mouseButton, const ResourceRequest& resourceRequest, const String& frameName, WebFramePolicyListenerProxy* listener, API::Object* userData) override
> +        virtual void decidePolicyForNewWindowAction(WebPageProxy* page, WebFrameProxy* frame, const NavigationActionData& navigationActionData, const ResourceRequest& resourceRequest, const String& frameName, RefPtr<WebFramePolicyListenerProxy> listener, API::Object* userData) override

This 'listener' should get moved.

Comment 4 Anders Carlsson 2014-01-30 14:59:38 PST

Committed r163123: <http://trac.webkit.org/changeset/163123>