Bug 127948

Summary: Lots of API test assertion failures after r163093
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, ap, cgarcia, commit-queue, gustavo, mrobinson
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
none
more ports ap: review+

Tim Horton
Reported 2014-01-30 14:07:17 PST
WKView should clean stuff up when the process terminates for any reason, not just a crash. Rename the function and make it clear the ViewGestureController. Also, don't make a ViewGestureController if we don't need one (if we don't have one, and the custom swipe view array is being cleared).
Attachments
patch (7.11 KB, patch)
2014-01-30 14:12 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
more ports (8.92 KB, patch)
2014-01-30 14:27 PST, Tim Horton 		ap: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-01-30 14:12:42 PST
Created attachment 222734 [details] patch
Tim Horton
Comment 2 2014-01-30 14:27:11 PST
Created attachment 222737 [details] more ports
WebKit Commit Bot
Comment 3 2014-01-30 14:28:12 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Alexey Proskuryakov
Comment 4 2014-01-30 14:41:57 PST
Comment on attachment 222737 [details] more ports Sadly, having a red tree means that EWS is slow, and doesn't tell us about this patch (or other new patches) quickly enough.
Tim Horton
Comment 5 2014-01-30 14:45:10 PST
http://trac.webkit.org/changeset/163116
Note You need to log in before you can comment on or make changes to this bug.