Bug 127947

Summary:

Don't ask AVFoundation for preferredTransform until it is available

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

ASSIGNED

Severity:

Normal

CC:

buildbot, commit-queue, glenn, jer.noble, philipj, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	jer.noble: review+
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2	none

Eric Carlson

Reported 2014-01-30 13:42:53 PST

@"preferredTransform" is a blocking sync property so don't ask for it unless it is available.

Attachments
Proposed patch (2.22 KB, patch) 2014-01-30 13:47 PST, Eric Carlson	jer.noble: review+	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (672.11 KB, application/zip) 2014-01-30 14:45 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (1.55 MB, application/zip) 2014-01-30 20:23 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (1.54 MB, application/zip) 2014-01-30 21:18 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Eric Carlson

Comment 1 2014-01-30 13:47:14 PST

Created attachment 222728 [details] Proposed patch

Jer Noble

Comment 2 2014-01-30 13:49:09 PST

Comment on attachment 222728 [details] Proposed patch nice, r=me.

Build Bot

Comment 3 2014-01-30 14:45:49 PST

Comment on attachment 222728 [details] Proposed patch Attachment 222728 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5207446586916864 New failing tests: media/video-controls-in-media-document.html media/video-frame-accurate-seek.html media/video-canvas-drawing-output.html media/video-aspect-ratio.html media/video-transformed.html media/video-canvas-alpha.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html media/track/track-cue-rendering-horizontal.html media/video-zoom.html media/video-poster-delayed.html media/controls-styling-strict.html media/track/track-cue-rendering-snap-to-lines-not-set.html media/controls-without-preload.html webgl/1.0.2/conformance/textures/texture-npot-video.html media/controls-after-reload.html http/tests/canvas/webgl/origin-clean-conformance.html webgl/1.0.1/conformance/textures/texture-npot-video.html webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/track/track-cue-rendering-rtl.html media/video-no-audio.html media/controls-strict.html webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/video-canvas-drawing.html media/video-colorspace-yuv420.html media/video-colorspace-yuv422.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html media/video-canvas-source.html fast/canvas/webgl/oes-texture-half-float-with-video.html

Build Bot

Comment 4 2014-01-30 14:45:51 PST

Created attachment 222740 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 5 2014-01-30 20:23:35 PST

Comment on attachment 222728 [details] Proposed patch Attachment 222728 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5786887872577536 New failing tests: media/video-controls-in-media-document.html media/video-frame-accurate-seek.html media/video-canvas-drawing-output.html media/video-aspect-ratio.html media/video-transformed.html media/video-canvas-alpha.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html media/track/track-cue-rendering-horizontal.html media/video-zoom.html media/video-poster-delayed.html media/controls-styling-strict.html media/track/track-cue-rendering-snap-to-lines-not-set.html media/controls-without-preload.html webgl/1.0.2/conformance/textures/texture-npot-video.html http/tests/canvas/webgl/origin-clean-conformance.html webgl/1.0.1/conformance/textures/texture-npot-video.html webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/track/track-cue-rendering-rtl.html media/video-no-audio.html media/controls-strict.html webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/video-canvas-drawing.html media/video-colorspace-yuv420.html media/video-colorspace-yuv422.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html media/video-canvas-source.html fast/canvas/webgl/oes-texture-half-float-with-video.html

Build Bot

Comment 6 2014-01-30 20:23:36 PST

Created attachment 222790 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 7 2014-01-30 21:18:47 PST

Comment on attachment 222728 [details] Proposed patch Attachment 222728 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5018510975565824 New failing tests: media/video-controls-in-media-document.html media/video-frame-accurate-seek.html media/video-canvas-drawing-output.html media/video-aspect-ratio.html media/video-transformed.html media/video-canvas-alpha.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba4444.html media/track/track-cue-rendering-horizontal.html media/video-zoom.html media/video-poster-delayed.html media/controls-styling-strict.html media/track/track-cue-rendering-snap-to-lines-not-set.html media/controls-without-preload.html webgl/1.0.2/conformance/textures/texture-npot-video.html http/tests/canvas/webgl/origin-clean-conformance.html webgl/1.0.1/conformance/textures/texture-npot-video.html webgl/1.0.2/conformance/extensions/oes-texture-float-with-video.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video-rgba5551.html webgl/1.0.2/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/track/track-cue-rendering-rtl.html media/video-no-audio.html media/controls-strict.html webgl/1.0.1/conformance/textures/tex-image-and-sub-image-2d-with-video.html media/video-canvas-drawing.html media/video-colorspace-yuv420.html media/video-colorspace-yuv422.html fast/canvas/webgl/tex-image-and-sub-image-2d-with-video.html media/video-canvas-source.html fast/canvas/webgl/oes-texture-half-float-with-video.html

Build Bot

Comment 8 2014-01-30 21:18:49 PST

Created attachment 222791 [details] Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-14 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Note You need to log in before you can comment on or make changes to this bug.