| Summary: | Web Inspector: Add Console support to JSContext Inspection | ||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||||||||||||
| Component: | Web Inspector | Assignee: | Joseph Pecoraro <joepeck> | ||||||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||||||
| Severity: | Normal | CC: | commit-queue, ggaren, graouts, joepeck, mark.lam, oliver, timothy, webkit-bug-importer | ||||||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||||||||
| Hardware: | All | ||||||||||||||||||
| OS: | All | ||||||||||||||||||
| Attachments: |
|
||||||||||||||||||
Created attachment 223006 [details]
[PATCH] Proposed Fix
One test is failing after this, so cq- while I work on that. Also, I expect to see triage other port build issues.
This doesn't send messages on exceptions yet. This is just all the machinery (ConsoleAgent) needed to make that possible. Attachment 223006 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/WebConsoleAgent.cpp:110: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4]
ERROR: Source/WebCore/inspector/CommandLineAPIHost.h:67: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/workers/WorkerMessagingProxy.cpp:49: Alphabetical sorting problem. [build/include_order] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 10 in 147 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 223006 [details]
[PATCH] Proposed Fix
r=me, once the build works
Created attachment 223014 [details]
[PATCH] For Bots
Attachment 223014 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 7 in 147 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 223023 [details]
[PATCH] For Bots 2
This patch fixes the test and actually gets a test progression. I haven't yet run all tests though, just inspector related ones.
Attachment 223023 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 7 in 149 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 223049 [details]
[PATCH] For Bots 3
Fixed a Windows and GTK issue.
Attachment 223049 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 7 in 149 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 223077 [details]
[PATCH] For Bots 4
Try the bots again, same patch rebased.
Attachment 223077 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 7 in 149 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Mac bots are yellow, meaning that there are a lot of flakes. I think it might have a legitimate issue with: http/tests/inspector-protocol/loading-iframe-document-node.html But I'm not sure if this patch introduced it. I feel like that is a separate issue (listing isolated contexts they somehow have the same ExecState as the main context)? (In reply to comment #15) > I think it might have a legitimate issue with: > http/tests/inspector-protocol/loading-iframe-document-node.html > > But I'm not sure if this patch introduced it. I feel like that is a separate issue (listing isolated contexts they somehow have the same ExecState as the main context)? Well, I verified this is caused by my patch. I'll debug it. Created attachment 223360 [details]
[PATCH] For Bots 5
Fixed the test failure. I have a good feeling about this one.
Attachment 223360 [details] did not pass style-queue:
ERROR: Source/WebCore/loader/ImageLoader.cpp:298: When wrapping a line, only indent 4 spaces. [whitespace/indent] [3]
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 8 in 151 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 223374 [details]
[PATCH] For Bots 6
Attachment 223374 [details] did not pass style-queue:
ERROR: Source/WebCore/inspector/InspectorConsoleInstrumentation.h:190: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/generate-combined-inspector-json.py:69: blank line at end of file [pep8/W391] [5]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:32: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:33: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/JavaScriptCore/inspector/ConsoleTypes.h:39: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:227: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
ERROR: Source/WebCore/inspector/InspectorInstrumentation.h:407: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5]
Total errors found: 7 in 151 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|
We need the ConsoleAgent in JavaScriptCore for JSContext inspection for things like: - backend sending console messages to frontend on exceptions - eventually hooking into $1..$9 CommandLineAPI support in a non-Web context (DOM Nodes / Profiles Nodes)