Bug 127939 – Begin fleshing out the navigation delegate

• Component: New Bugs
• Status: RESOLVED FIXED

[Anders Carlsson]

Begin fleshing out the navigation delegate

[Anders Carlsson]

Created attachment 222718 [details]
Patch

[WebKit Commit Bot]

Attachment 222718 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment on attachment 222718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222718&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.h:73
> +    WKWebView* m_webView;

Star on the wrong side.

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:110
> +            case WKNavigationPolicyDecisionAllow:
> +                listener->use();
> +                break;
> +
> +            case WKNavigationPolicyDecisionCancel:
> +                listener->ignore();
> +                break;
> +
> +            case WKNavigationPolicyDecisionDownload:
> +                listener->download();

This is over-indented.

Also, this looks like it breaks the tests.

[Anders Carlsson]

Committed r163108: <http://trac.webkit.org/changeset/163108>