Bug 127939

Summary:

Begin fleshing out the navigation delegate

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2014-01-30 12:57:03 PST

Begin fleshing out the navigation delegate

Comment 1 Anders Carlsson 2014-01-30 13:02:17 PST

Created attachment 222718 [details]
Patch

Comment 2 WebKit Commit Bot 2014-01-30 13:03:42 PST

Attachment 222718 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/NavigationState.h:64:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
ERROR: Source/WebKit2/UIProcess/API/APIPolicyClient.h:54:  The parameter type should use PassRefPtr instead of RefPtr.  [readability/pass_ptr] [5]
Total errors found: 2 in 8 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 mitz 2014-01-30 13:14:22 PST

Comment on attachment 222718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222718&action=review

> Source/WebKit2/UIProcess/Cocoa/NavigationState.h:73
> +    WKWebView* m_webView;

Star on the wrong side.

> Source/WebKit2/UIProcess/Cocoa/NavigationState.mm:110
> +            case WKNavigationPolicyDecisionAllow:
> +                listener->use();
> +                break;
> +
> +            case WKNavigationPolicyDecisionCancel:
> +                listener->ignore();
> +                break;
> +
> +            case WKNavigationPolicyDecisionDownload:
> +                listener->download();

This is over-indented.

Comment 4 mitz 2014-01-30 13:16:13 PST

Also, this looks like it breaks the tests.

Comment 5 Anders Carlsson 2014-01-30 13:23:30 PST

Committed r163108: <http://trac.webkit.org/changeset/163108>