Bug 127922 – [jhbuild] Disable escape sequences in EWS output

• Component: New Bugs
• Status: RESOLVED FIXED

[Csaba Osztrogonác]

discussion on webkit-dev:

https://lists.webkit.org/pipermail/webkit-dev/2014-January/026137.html
https://lists.webkit.org/pipermail/webkit-dev/2014-January/026140.html


The root of the problem is that jhbuild's output contains VT100 escape sequences.
I checked it and I think we can avoid it with setting TERM variable anything
different from xterm and rxvt. But we should do it for EWS bots only from
somewhere in webkitpy.

[Csaba Osztrogonác]

I tried a hack locally, added the following line to
disable_gcc_smartquotes() in environment.py:
self.env['TERM'] = 'none'

And then "webkit-patch build" doesn't generate 
escape sequences for me during jhbuild run.

[Csaba Osztrogonác]

Created attachment 222687 [details]
Patch

patch for EWS, it should fail only on EFL

[Csaba Osztrogonác]

Created attachment 222692 [details]
Patch

[Csaba Osztrogonác]

Comment on attachment 222692 [details]
Patch

clear r?, because it broke a webkitpy unit test :(
I'm going to fix it tomorrow morning.

[Csaba Osztrogonác]

Created attachment 222715 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 222715 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222715&action=review

> Tools/Scripts/webkitpy/common/system/environment.py:45
> +        # or rxvt, which makes webkit-queues server set wrong MIME type.

Correction, it's not happening in webkit-queues server, it's in browser (CFNetwork framework in Safari case, and I don't even know if other browsers are affected).

Also, the escape sequences would be harmful even if they didn't affect MIME type, because it's just garbage when viewed in browser.

[Csaba Osztrogonác]

Landed in http://trac.webkit.org/changeset/163167 after I corrected the comment.

[Carlos Alberto Lopez Perez]

FTR ... I'm going to propose to change TERM=none to TERM=dumb in bug 176761

TERM=none is invalid. In the case of JHBuild it disables VT100 codes. But it doesn't work with other programs like tput or GCC colored format.

TERM=dumb is valid and tells the terminal control code to disable any VT100 output. It disables JHBuild color codes as well as GCC color format or any other program that relies on tput or similar. Check : https://en.wikipedia.org/wiki/Computer_terminal#Dumb_terminals

$ TERM=xterm tput bold|xxd
00000000: 1b5b 316d                                .[1m

$ TERM=none tput bold|xxd
tput: unknown terminal "none"

$ TERM=dumb tput bold|xxd

# nothing ^