Summary: | IDB: Index cursor preliminary support | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jon Lee <jonlee> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 124521 | ||||||
Attachments: |
|
Description
Jon Lee
2014-01-29 16:30:16 PST
The way advance() and iterate() are implemented, getting index cursors up and running *at all* will get both of those up and running partially. Retitling this bug to: IDB: Index cursor preliminary support Retitling bug https://bugs.webkit.org/show_bug.cgi?id=127870 to: IDB: Index cursor complete advance() and iterate() support Created attachment 222847 [details]
Patch v1
Style bot has two legitimate complaints - Fixed locally. Attachment 222847 [details] did not pass style-queue:
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:66: Place brace on its own line for function definitions. [whitespace/braces] [4]
ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/SQLiteIDBCursor.cpp:113: Place brace on its own line for function definitions. [whitespace/braces] [4]
Total errors found: 2 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|