IDB: Index reading

• Component: WebCore Misc.
• Status: RESOLVED FIXED

[Jon Lee]

IDB: Index reading/writing

<rdar://problem/15899973>

[Brady Eidson]

This will be done in two separate patches.

Index writing is first.  It's straightforward and easy to verify by manual debugging and manual inspection on disk that it is working as expected.

Index reading will actually be implemented in terms of index cursors later.

[Brady Eidson]

Created attachment 222799 [details]
Index *writing* patch, v1

[WebKit Commit Bot]

Attachment 222799 [details] did not pass style-queue:


ERROR: Source/WebKit2/DatabaseProcess/IndexedDB/UniqueIDBDatabaseBackingStore.h:71:  The parameter name "key" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brady Eidson]

Created attachment 222800 [details]
Writing v2 - Fix style nit.

[Anders Carlsson]

Comment on attachment 222800 [details]
Writing v2 - Fix style nit.

View in context: https://bugs.webkit.org/attachment.cgi?id=222800&action=review

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:239
> +            IDBIndexMetadata idxMetadata;

No need to abbreviate index here.

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:256
> +            auto objectStoreMetadata = metadata->objectStores.find(objectStoreID);

I'd call this objectStoreMetadataIt to indicate that it's an iterator (especially since you're using auto).

[Brady Eidson]

http://trac.webkit.org/changeset/163170

[Brady Eidson]

Retitling to reflect that only reading remains.

[Brady Eidson]

Created attachment 222877 [details]
Reading patch v1 - Implement with a cursor!

[Jer Noble]

Comment on attachment 222877 [details]
Reading patch v1 - Implement with a cursor!

View in context: https://bugs.webkit.org/attachment.cgi?id=222877&action=review

r=me with obligatory nit.

> Source/WebKit2/DatabaseProcess/IndexedDB/sqlite/UniqueIDBDatabaseBackingStoreSQLite.cpp:837
> +

Ob-nit: Unnecessary whitespace.

[Brady Eidson]

http://trac.webkit.org/changeset/163246

[Tim Nguyen (:ntim)]

*** Bug 116223 has been marked as a duplicate of this bug. ***