Bug 127858

Summary:

[MediaControls] Fix errors pointed out by JSHint.

Product:

WebKit

Reporter:

Jer Noble <jer.noble>

Component:

New Bugs

Assignee:

Jer Noble <jer.noble>

Status:

NEW

Severity:

Normal

CC:

aqeelalamdp, buildbot, commit-queue, eric.carlson, glenn, philipj, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion	none

Jer Noble

Reported 2014-01-29 14:38:22 PST

[MediaControls] Fix errors pointed out by JSHint.

Attachments
Patch (7.80 KB, patch) 2014-01-29 14:45 PST, Jer Noble	eric.carlson: review+ buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (456.11 KB, application/zip) 2014-01-29 15:39 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (484.86 KB, application/zip) 2014-01-29 16:04 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion (538.39 KB, application/zip) 2014-01-29 16:18 PST, Build Bot	no flags	Details
View All Add attachment proposed patch, testcase, etc.

Jer Noble

Comment 1 2014-01-29 14:45:43 PST

Created attachment 222597 [details] Patch

Build Bot

Comment 2 2014-01-29 15:39:24 PST

Comment on attachment 222597 [details] Patch Attachment 222597 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6318179152297984 New failing tests: webarchive/loading/video-in-webarchive.html

Build Bot

Comment 3 2014-01-29 15:39:25 PST

Created attachment 222600 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-01-29 16:04:51 PST

Comment on attachment 222597 [details] Patch Attachment 222597 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6459170580594688 New failing tests: webarchive/loading/video-in-webarchive.html

Build Bot

Comment 5 2014-01-29 16:04:54 PST

Created attachment 222603 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-01-29 16:18:34 PST

Comment on attachment 222597 [details] Patch Attachment 222597 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4747584975405056 New failing tests: webarchive/loading/video-in-webarchive.html

Build Bot

Comment 7 2014-01-29 16:18:36 PST

Created attachment 222605 [details] Archive of layout-test-results from webkit-ews-05 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-05 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Note You need to log in before you can comment on or make changes to this bug.