Bug 127819

Summary: [iOS] round the scrollview content size to natural numbers
Product: WebKit Reporter: Benjamin Poulain <benjamin>
Component: New BugsAssignee: Benjamin Poulain <benjamin>
Status: RESOLVED INVALID    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Benjamin Poulain
Reported 2014-01-28 17:39:04 PST
[iOS] round the scrollview content size to natural numbers
Attachments
Patch (1.99 KB, patch)
2014-01-28 17:45 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2014-01-28 17:45:30 PST
Created attachment 222536 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-01-29 16:32:54 PST
Comment on attachment 222536 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222536&action=review > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:110 > - CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(newSize.width * zoomScale, newSize.height * zoomScale); > + CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(std::round(newSize.width * zoomScale), std::round(newSize.height * zoomScale)); Should we also adjust the scale so it still reflects the scaling after rounding?
Benjamin Poulain
Comment 3 2014-01-29 16:55:01 PST
(In reply to comment #2) > (From update of attachment 222536 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=222536&action=review > > > Source/WebKit2/UIProcess/API/ios/WKViewIOS.mm:110 > > - CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(newSize.width * zoomScale, newSize.height * zoomScale); > > + CGSize contentsSizeInScrollViewCoordinates = CGSizeMake(std::round(newSize.width * zoomScale), std::round(newSize.height * zoomScale)); > > Should we also adjust the scale so it still reflects the scaling after rounding? That sounds like a good idea.
Benjamin Poulain
Comment 4 2014-01-30 15:48:22 PST
Comment on attachment 222536 [details] Patch Simon pointed out this is incomplete.
Benjamin Poulain
Comment 5 2014-08-19 22:34:35 PDT
I fixed that somewhere else IIRC.
Note You need to log in before you can comment on or make changes to this bug.