Web Inspector: [REGRESSION(r162931)] Tab navigation broken in DataGrid

• Component: Web Inspector
• Status: RESOLVED FIXED

[Diego Pino]

Tab navigation in the DataGrid doesn't work properly after r162931. How to reproduce:

* Fill a DataGrid (for example LocalStorage) with two rows of data.
* Edit row1.key and press tab.

Expected result: cursor moves to row1.value.
Actual result: cursor moves to row2.key.

After r162931, columnIdentifier is a string. It's necessary to change comparisons of columnIdentifier in 'moveToNextIfNeeded' (function that handles tab navigation) to string values.

[Radar WebKit Bug Importer]

<rdar://problem/15931228>

[Diego Pino]

Created attachment 222528 [details]
Patch

[Timothy Hatcher]

Comment on attachment 222528 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222528&action=review

> Source/WebInspectorUI/UserInterface/DataGrid.js:361
>                      return this._startEditingColumnOfDataGridNode(currentEditingNode, 1);

There are a few 1s and 0s in this function that should also be strings for clarity. Right now they are being converted later into string.

> Source/WebInspectorUI/UserInterface/DataGrid.js:375
>                      return this._startEditingColumnOfDataGridNode(currentEditingNode, 0);

Another 0, but there are more.

[Timothy Hatcher]

This code is so confused… it assumes only two columns with numeric identifiers. Sigh.

[Diego Pino]

Created attachment 222562 [details]
Patch

[Diego Pino]

Created attachment 222566 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 222566 [details]
Patch

Clearing flags on attachment: 222566

Committed r163015: <http://trac.webkit.org/changeset/163015>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.