Bug 127799

Summary: Web Inspector: Tweak UI when debugging a JSContext
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Joseph Pecoraro <joepeck>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix
timothy: review+
[IMAGE] JSContext Inspection none

Description Joseph Pecoraro 2014-01-28 14:26:29 PST
- Remove Inspect button
- Hide Timelines navigation panel (currently unsupported)
- Show small Dashboard with just errors, warnings, logs (resources count, resources size, and time don't make sense)
- for JavaScript scripts that would go into "Extra Scripts" put them instead at the top level in the Resources sidebar.
  => adjust style so this looks good by default with .hide-disclosure-buttons
Comment 1 Radar WebKit Bug Importer 2014-01-28 14:29:55 PST
<rdar://problem/15929529>
Comment 2 Joseph Pecoraro 2014-01-28 14:30:51 PST
Created attachment 222491 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2014-01-28 14:31:16 PST
Created attachment 222492 [details]
[IMAGE] JSContext Inspection
Comment 4 Timothy Hatcher 2014-01-28 14:34:56 PST
Comment on attachment 222491 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=222491&action=review

> Source/WebInspectorUI/UserInterface/Main.js:45
> +}

};

> Source/WebInspectorUI/UserInterface/Main.js:192
> +    this.toolbar.element.classList.add(this.debuggableType);

We might eventually want to put this on the body so any element can select off it.
Comment 5 Joseph Pecoraro 2014-01-28 14:38:36 PST
(In reply to comment #4)
> (From update of attachment 222491 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=222491&action=review
> 
> > Source/WebInspectorUI/UserInterface/Main.js:45
> > +}
> 
> };
> 
> > Source/WebInspectorUI/UserInterface/Main.js:192
> > +    this.toolbar.element.classList.add(this.debuggableType);
> 
> We might eventually want to put this on the body so any element can select off it.

Good idea. I'll do that now.
Comment 6 Joseph Pecoraro 2014-01-28 14:42:53 PST
Landed <http://trac.webkit.org/changeset/162965>.