Bug 127797

Summary: Make DOM attributes appear to be faux accessor properties
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: aestes, alecflett, cdumez, cgarcia, commit-queue, eric.carlson, glenn, jer.noble, jsbell, philipj
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127825    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Oliver Hunt 2014-01-28 14:15:46 PST 
Make DOM attributes appear to be faux accessor properties
Comment 1 Oliver Hunt 2014-01-28 14:23:41 PST 
Created attachment 222490 [details]
Patch
Comment 2 Filip Pizlo 2014-01-28 14:29:27 PST 
Comment on attachment 222490 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=222490&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:2336
> +                    if ($interfaceName eq "DOMWindow" && $className eq "JSblah") {
> +                        # FIXME: This branch never executes and should be removed.

You're not inspiring confidence here.  What's "JSblah"?
Comment 3 Oliver Hunt 2014-01-28 14:46:46 PST 
Created attachment 222495 [details]
Patch
Comment 4 Oliver Hunt 2014-01-28 17:08:40 PST 
Committed r162987: <http://trac.webkit.org/changeset/162987>
Comment 5 Andy Estes 2014-01-28 20:00:20 PST 
This broke Release builds, as indicated by the three EWS failures. Also see <http://build.webkit.org/builders/Apple%20MountainLion%20Release%20%28Build%29/builds/17668/steps/compile-webkit/logs/stdio>.
Comment 6 WebKit Commit Bot 2014-01-28 20:10:28 PST 
Re-opened since this is blocked by bug 127825
Comment 7 Andy Estes 2014-01-28 20:22:28 PST 
Mountain Lion probably has an older version of Perl. You need to dereference your array references on all the calls to push().
Comment 8 Oliver Hunt 2014-01-29 11:27:38 PST 
Created attachment 222586 [details]
Patch
Comment 9 Oliver Hunt 2014-01-29 12:29:03 PST 
Committed r163035: <http://trac.webkit.org/changeset/163035>
Comment 10 Geoffrey Garen 2014-01-29 13:14:40 PST 
Comment on attachment 222586 [details]
Patch

Clearing review flag because this was committed.