Summary: | REGRESSION: Nightly won't load Curl plugin for full page use | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | William Bardwell <wbardwel> | ||||
Component: | Plug-ins | Assignee: | Alexey Proskuryakov <ap> | ||||
Status: | VERIFIED FIXED | ||||||
Severity: | Major | CC: | andersca, ap | ||||
Priority: | P1 | Keywords: | InRadar, Regression | ||||
Version: | 420+ | ||||||
Hardware: | Mac | ||||||
OS: | OS X 10.4 | ||||||
Attachments: |
|
Description
William Bardwell
2007-02-15 15:14:21 PST
Is this a Netscape plug-in? If so, does it work in Firefox on the same Mac? Are there any error/warning messages that appear on the console or in a log file when you try to load a file that uses the plug-in? What does the Activity window show? And, most importantly - is there a way for us to reproduce the problem? If confirmed, this would be a P1 bug. You can download a version of my product and go to demos that use it at: www.curl.com It works with 419.3 but not with a recent nightly. The problem here is that WebHTMLView claims support for all "text/" MIME types, and +[WebView _viewClass:andRepresentationClass:forMIMEType:] doesn't even look at plugins if internal support is found. It's easy to suggest a number of easy fixes for this, but choosing the correct one may be more tricky. What MIME type does this plugin want to use? The key type is "text/vnd.curl" (but it registers some others that are only ever used for plugin detection JavaScript code.) Created attachment 13911 [details]
proposed fix
My diagnosis was wrong - it's fine for +[WebView _viewClass:andRepresentationClass:forMIMEType:] to return WebHTMLView/WebHTMLRepresentation, as plugins are also handled by these.
The actual problem seems to be in DOMImplementation::createDocument(), which hates plugins (it also mishandles Adobe SVG and any xml MIME types now).
I don't know how to make a test for this fix.
Comment on attachment 13911 [details]
proposed fix
Looks good. r=me
Committed revision 20648. This does fix the problem for me. (To make a test, you need a plugin that tries to take text/<something> and make sure that it gets loaded if you load a url with that as the mime-type.) (In reply to comment #11) > This does fix the problem for me. Great - so, marking as VERIFIED. IIRC, this problem was blocking you from verifying some other plugin issues with TOT (nightly) - could you please check those? > (To make a test, you need a plugin that tries to take text/<something> and > make sure that it gets loaded if you load a url with that as the mime-type.) Yes, that's how I tested when making this patch - but this doesn't translate into automated test easily, because the plugin has to be full page. |