Bug 12778 – REGRESSION: Nightly won't load Curl plugin for full page use

• Component: Plug-ins
• Status: VERIFIED FIXED

[William Bardwell]

A Nightly from Feb 14 2007 won't load my plugin if you browse to a URL that is for a file handled by the plugin.  The plugin is listed in the Installed Plugin-ins page, and I do seem to be able to load flash stuff from a .swf url.

This plugin works in Safari 2.0.4 419.3, and it works if used from an OBJECT tag.

[David Kilzer (:ddkilzer)]

Is this a Netscape plug-in?  If so, does it work in Firefox on the same Mac?

Are there any error/warning messages that appear on the console or in a log file when you try to load a file that uses the plug-in?

What does the Activity window show?

[Alexey Proskuryakov]

And, most importantly - is there a way for us to reproduce the problem?

If confirmed, this would be a P1 bug.

[William Bardwell]

You can download a version of my product and go to demos that use it at:
www.curl.com

It works with 419.3 but not with a recent nightly.

[Alexey Proskuryakov]

The problem here is that WebHTMLView claims support for all "text/" MIME types, and +[WebView _viewClass:andRepresentationClass:forMIMEType:] doesn't even look at plugins if internal support is found.

It's easy to suggest a number of easy fixes for this, but choosing the correct one may be more tricky.

[Maciej Stachowiak]

What MIME type does this plugin want to use?

[William Bardwell]

The key type is "text/vnd.curl" (but it registers some others that are only ever used for plugin detection JavaScript code.)

[Maciej Stachowiak]

<rdar://problem/5028153>

[Alexey Proskuryakov]

Created attachment 13911 [details]
proposed fix

My diagnosis was wrong - it's fine for +[WebView _viewClass:andRepresentationClass:forMIMEType:] to return WebHTMLView/WebHTMLRepresentation, as plugins are also handled by these.

The actual problem seems to be in DOMImplementation::createDocument(), which hates plugins (it also mishandles Adobe SVG and any xml MIME types now).

I don't know how to make a test for this fix.

[Darin Adler]

Comment on attachment 13911 [details]
proposed fix

Looks good. r=me

[Alexey Proskuryakov]

Committed revision 20648.

[William Bardwell]

This does fix the problem for me.
(To make a test, you need a plugin that tries to take text/<something> and
make sure that it gets loaded if you load a url with that as the mime-type.)

[Alexey Proskuryakov]

(In reply to comment #11)
> This does fix the problem for me.

  Great - so, marking as VERIFIED. IIRC, this problem was blocking you from verifying some other plugin issues with TOT (nightly) - could you please check those?

> (To make a test, you need a plugin that tries to take text/<something> and
> make sure that it gets loaded if you load a url with that as the mime-type.)

  Yes, that's how I tested when making this patch - but this doesn't translate into automated test easily, because the plugin has to be full page.