Bug 127765

Summary: build.webkit.org/dashboard links to an old failing build rather than the most recent
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: Tools / TestsAssignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, mrowe, thorton, timothy
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
WIP fix
none
proposed patch
none
screenshot before
none
screenshot after none

Alexey Proskuryakov
Reported 2014-01-28 00:27:07 PST
It is very confusing when the build is being iteratively fixed, as we get links to the old errors. <rdar://problem/15795228>
Attachments
WIP fix (9.83 KB, patch)
2014-01-28 00:40 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
proposed patch (11.88 KB, patch)
2014-01-28 16:48 PST, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
screenshot before (381.06 KB, image/png)
2014-01-28 16:48 PST, Alexey Proskuryakov 		no flags
Details
screenshot after (368.27 KB, image/png)
2014-01-28 16:48 PST, Alexey Proskuryakov 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-01-28 00:40:36 PST
Created attachment 222414 [details] WIP fix One thing that's missing from this patch is displaying something reasonable when there is a mix of build failures and interruptions. For example, we should probably display an orange bubble and a red one for something like this: Jan 11 22:23 161800 exception #1129 Exception interrupted Jan 11 22:21 161799 failure #1128 Failed compile-webkit Jan 11 22:20 161798 failure #1127 Failed compile-webkit The current patch displays an orange bubble, and then a green one for latest success, hiding the fact that the latest real outcome was a build failure.
Alexey Proskuryakov
Comment 2 2014-01-28 16:48:14 PST
Created attachment 222532 [details] proposed patch I'm actually not sure how to fit this much information here. I think that this patch is an improvement, and further improvement would require adding a view with much more history than can fit inline (e.g. to show latest 20 or 50 iterations).
Alexey Proskuryakov
Comment 3 2014-01-28 16:48:36 PST
Created attachment 222533 [details] screenshot before
Alexey Proskuryakov
Comment 4 2014-01-28 16:48:51 PST
Created attachment 222534 [details] screenshot after
WebKit Commit Bot
Comment 5 2014-01-29 11:31:18 PST
Comment on attachment 222532 [details] proposed patch Clearing flags on attachment: 222532 Committed r163029: <http://trac.webkit.org/changeset/163029>
WebKit Commit Bot
Comment 6 2014-01-29 11:31:20 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.