Bug 127728

Summary: Expose SQL database creation and modification times
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: beidson, commit-queue, mark.lam, mhock
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch beidson: review+

Description Alexey Proskuryakov 2014-01-27 16:38:31 PST 
Would like clients to have access to database creation and modification time.

<rdar://problem/15642467>
Comment 1 Alexey Proskuryakov 2014-01-27 16:45:50 PST 
Created attachment 222380 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-01-27 16:47:29 PST 
Attachment 222380 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp:488:  An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
ERROR: Source/WebCore/Modules/webdatabase/DatabaseManager.cpp:56:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brady Eidson 2014-01-27 17:02:12 PST 
Comment on attachment 222380 [details]
proposed patch

Work through the build fixes, then r+
Comment 4 Alexey Proskuryakov 2014-01-28 10:14:39 PST 
Committed <http://trac.webkit.org/r162943> with a Gtk build fix.