Bug 127712

Summary: Web Inspector: Feature Check all Protocol Generated Interfaces to get JSContext Inspection working
Product: WebKit Reporter: Joseph Pecoraro <joepeck>
Component: Web InspectorAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
[PATCH] Proposed Fix none

Joseph Pecoraro
Reported 2014-01-27 14:37:25 PST
Attempting to open an inspector for a JSContext results in runtime exceptions for protocol generated interfaces (e.g. NetworkAgent, CSSAgent, DOMAgent, etc) that were expected to exist when debugging a WebCore::Page but do not exist when debugging a JSContext. Feature check all of these points before they are used, and JSContext inspection works!
Attachments
[PATCH] Proposed Fix (13.69 KB, patch)
2014-01-27 14:48 PST, Joseph Pecoraro 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-27 14:37:46 PST
<rdar://problem/15919014>
Joseph Pecoraro
Comment 2 2014-01-27 14:48:53 PST
Created attachment 222366 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 3 2014-01-27 15:20:42 PST
Comment on attachment 222366 [details] [PATCH] Proposed Fix Clearing flags on attachment: 222366 Committed r162874: <http://trac.webkit.org/changeset/162874>
WebKit Commit Bot
Comment 4 2014-01-27 15:20:44 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.