Summary: | Scrub WebKit API headers of WTF macros | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||||
Component: | WebKit API | Assignee: | Andy Estes <aestes> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | cdumez, cgarcia, commit-queue, dbates, ddkilzer, eric.carlson, glenn, jer.noble, philipj, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Andy Estes
2014-01-27 13:46:49 PST
Created attachment 222353 [details]
Stop the code generator from adding ENABLE() macros to Objective-C DOM headers
Comment on attachment 222353 [details] Stop the code generator from adding ENABLE() macros to Objective-C DOM headers View in context: https://bugs.webkit.org/attachment.cgi?id=222353&action=review r=me > Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:800 > + my %defines = map { $_ => 1 } split(/\s+/, $definesString); It would be better to do this in GenerateHeader and pass in the hash than to recreate it every time. You can do this by declaring a subroutine prototype at the "top" of the perl script: sub ConditionalIsEnabled(\%$); and then add the argument prototypes above: sub ConditionalIsEnabled(\%$) { Then call it using: ConditionalIsEnabled(%defines, $mystring) > Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm:803 > + return exists($defines{"ENABLE_" . $conditional}); If making the change above, this becomes: return exists($defines->{"ENABLE_" . $conditional}); Committed r162872: <http://trac.webkit.org/changeset/162872> Created attachment 222370 [details]
Scrub WebKit API headers of WTF macros
Comment on attachment 222370 [details]
Scrub WebKit API headers of WTF macros
r=me
Committed r162881: <http://trac.webkit.org/changeset/162881> |