Bug 127680

Summary:

Update RenderImage when the image src is cleared

Product:

WebKit

Reporter:

Peter Molnar <pmolnar.u-szeged>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Normal

CC:

buildbot, bunhere, cdumez, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, japhet, kondapallykalyan, rniwa

Priority:

Keywords:

BlinkMergeCandidate

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
patch - fixed	none

Peter Molnar

Reported 2014-01-27 04:43:38 PST

When the src is removed via JavaScript, the image loader should update the renderer. Merged from Blink: https://src.chromium.org/viewvc/blink?revision=155294&view=revision

Attachments
patch (5.88 KB, patch) 2014-01-27 04:45 PST, Peter Molnar	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (451.85 KB, application/zip) 2014-01-27 05:41 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (505.34 KB, application/zip) 2014-01-27 07:00 PST, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (483.01 KB, application/zip) 2014-01-27 07:02 PST, Build Bot	no flags	Details
patch - fixed (8.22 KB, patch) 2014-01-27 07:02 PST, Peter Molnar	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Peter Molnar

Comment 1 2014-01-27 04:45:42 PST

Created attachment 222317 [details] patch

Build Bot

Comment 2 2014-01-27 05:41:20 PST

Comment on attachment 222317 [details] patch Attachment 222317 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6056235002494976 New failing tests: canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html

Build Bot

Comment 3 2014-01-27 05:41:22 PST

Created attachment 222320 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-01-27 07:00:22 PST

Comment on attachment 222317 [details] patch Attachment 222317 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5175508673232896 New failing tests: canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html

Build Bot

Comment 5 2014-01-27 07:00:25 PST

Created attachment 222324 [details] Archive of layout-test-results from webkit-ews-07 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-07 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 6 2014-01-27 07:02:07 PST

Comment on attachment 222317 [details] patch Attachment 222317 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4713059142598656 New failing tests: canvas/philip/tests/2d.drawImage.image.incomplete.omitted.html

Build Bot

Comment 7 2014-01-27 07:02:09 PST

Created attachment 222325 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Peter Molnar

Comment 8 2014-01-27 07:02:44 PST

Created attachment 222326 [details] patch - fixed Removed expected failure from platform/mac and unskipped the test on EFL and GTK.

Alexey Proskuryakov

Comment 9 2014-01-27 10:12:40 PST

Please see comments in bug 26285. I don't think that this Blink patch is good enough to be landed as is. *** This bug has been marked as a duplicate of bug 26285 ***

Note You need to log in before you can comment on or make changes to this bug.