Bug 127666

Summary: CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: REOPENED ---    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kangil.han, macpherson, menard, ossy, philipj, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127890    
Bug Blocks:    
Attachments:
Description Flags
Part 1
none
Part 1
none
Patch
none
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Description Sam Weinig 2014-01-26 18:36:27 PST
CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Comment 1 Sam Weinig 2014-01-26 18:57:38 PST
Created attachment 222295 [details]
Part 1
Comment 2 Sam Weinig 2014-01-26 19:01:16 PST
Comment on attachment 222295 [details]
Part 1

Not ready for prime time yet.
Comment 3 Sam Weinig 2014-01-26 19:12:54 PST
Created attachment 222296 [details]
Part 1
Comment 4 Sam Weinig 2014-01-26 20:47:46 PST
Created attachment 222300 [details]
Patch
Comment 5 Sam Weinig 2014-01-26 21:10:04 PST
Created attachment 222301 [details]
Patch
Comment 6 Build Bot 2014-01-29 13:57:06 PST
Comment on attachment 222301 [details]
Patch

Attachment 222301 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6466608323100672

New failing tests:
platform/mac/accessibility/aria-setsize-posinset.html
accessibility/canvas-fallback-content-2.html
accessibility/div-within-anchors-causes-crash.html
accessibility/canvas-description-and-role.html
platform/mac/accessibility/option-with-lang.html
Comment 7 Build Bot 2014-01-29 13:57:09 PST
Created attachment 222593 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Sam Weinig 2014-01-29 16:30:50 PST
Committed r163048: <http://trac.webkit.org/changeset/163048>
Comment 9 Alexey Proskuryakov 2014-01-29 23:31:09 PST
(In reply to comment #6)
> New failing tests:
> platform/mac/accessibility/aria-setsize-posinset.html
> accessibility/canvas-fallback-content-2.html
> accessibility/div-within-anchors-causes-crash.html
> accessibility/canvas-description-and-role.html
> platform/mac/accessibility/option-with-lang.html

How could this be landed over all these errors detected by EWS? There are even more on mac-wk1.
Comment 10 WebKit Commit Bot 2014-01-29 23:33:20 PST
Re-opened since this is blocked by bug 127890
Comment 12 Csaba Osztrogonác 2014-01-30 00:30:02 PST
The Windows buildfix http://trac.webkit.org/changeset/163052 rolled out 
by http://trac.webkit.org/changeset/163077 to fix the Windows build.