Bug 127666

Summary: CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: REOPENED    
Severity: Normal CC: buildbot, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, kangil.han, macpherson, menard, ossy, philipj, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127890    
Bug Blocks:    
Attachments:
Description Flags
Part 1
none
Part 1
none
Patch
none
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 none

Sam Weinig
Reported 2014-01-26 18:36:27 PST
CaptionUserPreferences should not be on the PageGroup if they are not really per-PageGroup
Attachments
Part 1 (88.24 KB, patch)
2014-01-26 18:57 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Part 1 (88.26 KB, patch)
2014-01-26 19:12 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (87.96 KB, patch)
2014-01-26 20:47 PST, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (88.39 KB, patch)
2014-01-26 21:10 PST, Sam Weinig 		eric.carlson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (495.58 KB, application/zip)
2014-01-29 13:57 PST, Build Bot 		no flags
Details
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-01-26 18:57:38 PST
Created attachment 222295 [details] Part 1
Sam Weinig
Comment 2 2014-01-26 19:01:16 PST
Comment on attachment 222295 [details] Part 1 Not ready for prime time yet.
Sam Weinig
Comment 3 2014-01-26 19:12:54 PST
Created attachment 222296 [details] Part 1
Sam Weinig
Comment 4 2014-01-26 20:47:46 PST
Created attachment 222300 [details] Patch
Sam Weinig
Comment 5 2014-01-26 21:10:04 PST
Created attachment 222301 [details] Patch
Build Bot
Comment 6 2014-01-29 13:57:06 PST
Comment on attachment 222301 [details] Patch Attachment 222301 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6466608323100672 New failing tests: platform/mac/accessibility/aria-setsize-posinset.html accessibility/canvas-fallback-content-2.html accessibility/div-within-anchors-causes-crash.html accessibility/canvas-description-and-role.html platform/mac/accessibility/option-with-lang.html
Build Bot
Comment 7 2014-01-29 13:57:09 PST
Created attachment 222593 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Sam Weinig
Comment 8 2014-01-29 16:30:50 PST
Committed r163048: <http://trac.webkit.org/changeset/163048>
Alexey Proskuryakov
Comment 9 2014-01-29 23:31:09 PST
(In reply to comment #6) > New failing tests: > platform/mac/accessibility/aria-setsize-posinset.html > accessibility/canvas-fallback-content-2.html > accessibility/div-within-anchors-causes-crash.html > accessibility/canvas-description-and-role.html > platform/mac/accessibility/option-with-lang.html How could this be landed over all these errors detected by EWS? There are even more on mac-wk1.
WebKit Commit Bot
Comment 10 2014-01-29 23:33:20 PST
Re-opened since this is blocked by bug 127890
Csaba Osztrogonác
Comment 12 2014-01-30 00:30:02 PST
The Windows buildfix http://trac.webkit.org/changeset/163052 rolled out by http://trac.webkit.org/changeset/163077 to fix the Windows build.
Note You need to log in before you can comment on or make changes to this bug.