| Summary: | JavaScriptCore: Enable -Wimplicit-fallthrough and add FALLTHROUGH annotation where needed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||||
| Component: | JavaScriptCore | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ggaren, joepeck, oliver | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
Created attachment 222265 [details]
[PATCH] Proposed Fix
Again, reviewers look carefully. This may have uncovered a latent bug with an accidental fallthrough.
Created attachment 222268 [details]
[PATCH] Proposed Fix
Landed <http://trac.webkit.org/changeset/162906>. |
This should go through a careful review. I don't think anything is controversial here. I can already see that engineers might want to include a comment with a FALLTHROUGH. For example: // fall through to Foo Could become: FALLTHROUGH; // To Foo. In the first patch I only left comments that seemed most apt to keep. Also filed a clang issue to make FALLTHROUGH nicer to use in the case and there are labels preceding the next case: http://llvm.org/bugs/show_bug.cgi?id=18621