Summary: | [GTK] Make webkit_uri_scheme_request_get_web_view() work with CustomProtocols | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Carlos Garcia Campos <cgarcia> | ||||||||
Component: | WebKit2 | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | bunhere, cdumez, commit-queue, danw, gustavo, gyuyoung.kim, mrobinson, svillar | ||||||||
Priority: | P2 | Keywords: | Gtk | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 127091 | ||||||||||
Attachments: |
|
Description
Carlos Garcia Campos
2014-01-25 00:40:49 PST
There's another solution that wouldn't need to change any cross-platform code: We could move the initiatingPageID to the ResourceRequest. In the willSendRequest callback we set the initiating page id (willSendRequest receives the frame, so we have the page) to the request we return. In ResourceHandle, when creating the soup request for the given request we attach the page id to the soup request the same way we are currently doing, but using the ResourceRequest instead of NetworkingContext. Then we can remove the initiatingPageID() method from NetworkingContext. I think this is actually moving the problem to another place, but at least we can implement it in platform specific code entirely. Created attachment 222201 [details]
Patch
Note that this doesn't affect EFL because they don't use the initiatingPageID.
Created attachment 222270 [details]
Updated patch
Comment on attachment 222270 [details]
Updated patch
yay
Created attachment 222318 [details]
Patch for landing
Want to make sure I haven't broken EFL.
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API Committed r162920: <http://trac.webkit.org/changeset/162920> |