Bug 127609

Summary: Update WebCrypto JWK mapping to use key_ops
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebCore Misc.Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 122679    
Attachments:
Description Flags
patch
none
proposed fix none

Description Alexey Proskuryakov 2014-01-24 22:31:16 PST
The way WebCrypto key usages are mapped to JWK has changed since we implemented it. It used to be a comma separated list in "use" attribute, and now they go into a different attribute, key_ops.
Comment 1 Alexey Proskuryakov 2014-01-24 22:31:58 PST
Changes in <https://dvcs.w3.org/hg/webcrypto-api/rev/05819fa07004>.
Comment 2 Alexey Proskuryakov 2014-01-30 16:43:33 PST
Created attachment 222759 [details]
patch

I have this implemented, but the patch breaks tests because of an underlying library issue accidentally uncovered by this change, <rdar://problem/15949992>.
Comment 3 Alexey Proskuryakov 2014-01-31 15:58:03 PST
Turns out it's more of a WebCrypto spec issue than a library issue. Tracking that as <https://www.w3.org/Bugs/Public/show_bug.cgi?id=24457>.
Comment 4 Alexey Proskuryakov 2014-01-31 16:08:07 PST
Created attachment 222862 [details]
proposed fix
Comment 5 WebKit Commit Bot 2014-02-01 10:09:33 PST
Comment on attachment 222862 [details]
proposed fix

Clearing flags on attachment: 222862

Committed r163244: <http://trac.webkit.org/changeset/163244>
Comment 6 WebKit Commit Bot 2014-02-01 10:09:36 PST
All reviewed patches have been landed.  Closing bug.