Bug 127600

Summary:

DebuggerCallFrame::evaluateWithCallFrame() should not execute a null executable

Product:

WebKit

Reporter:

Mark Lam <mark.lam>

Component:

JavaScriptCore

Assignee:

Mark Lam <mark.lam>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bburg, fpizlo, ggaren, mhahnenberg, msaboff, oliver, timothy

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
the patch.	oliver: review+

Mark Lam

Reported 2014-01-24 18:58:10 PST

In DebuggerCallFrame::evaluateWithCallFrame(), if the script string that is passed in is bad, it will fail to create an Executable i.e. EvalExecutable::create() returns null. However, DebuggerCallFrame::evaluateWithCallFrame() currently just clears the exception and proceeds to attempt to execute the Executable (which again is null). A crash ensues. DebuggerCallFrame::evaluateWithCallFrame() should abort if the Executable pointer is null. Patch coming.

Attachments
the patch. (1.69 KB, patch) 2014-01-24 19:08 PST, Mark Lam	oliver: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Mark Lam

Comment 1 2014-01-24 19:08:09 PST

Created attachment 222183 [details] the patch.

Mark Lam

Comment 2 2014-01-24 19:11:36 PST

Thanks. Landed in r162752: <http://trac.webkit.org/r162752>.

Geoffrey Garen

Comment 3 2014-01-27 11:40:30 PST

Regression test?

Mark Lam

Comment 4 2014-02-03 13:21:10 PST

(In reply to comment #3) > Regression test? Will work on regression test at https://bugs.webkit.org/show_bug.cgi?id=128121.

Note You need to log in before you can comment on or make changes to this bug.