Bug 127591

Summary: WebKit2 View Gestures: Crash when pinch-zooming on a page that is just a frameset
Product: WebKit Reporter: Tim Horton <thorton>
Component: Layout and RenderingAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, commit-queue, esprehn+autocc, glenn, kondapallykalyan, rniwa, simon.fraser
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
repro
none
patch
simon.fraser: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Tim Horton
Reported 2014-01-24 15:48:58 PST
We crash in TiledCoreAnimationDrawingArea::adjustTransientZoom, trying to play with a null shadow layer. However, we always want a shadow layer when pinch zooming (except in Beth's new rubber banding mode, but we'll have to decide what to do about that later), so we should have one (and this will also avoid crashing). <rdar://problem/15898349>
Attachments
repro (21 bytes, text/html)
2014-01-24 15:49 PST, Tim Horton 		no flags
Details
patch (10.45 KB, patch)
2014-01-24 18:02 PST, Tim Horton 		simon.fraser: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (1.60 MB, application/zip)
2014-01-24 18:29 PST, Build Bot 		no flags
Details
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-01-24 15:49:35 PST
Created attachment 222163 [details] repro
Tim Horton
Comment 2 2014-01-24 18:02:22 PST
Created attachment 222179 [details] patch
Tim Horton
Comment 3 2014-01-24 18:03:25 PST
Comment on attachment 222179 [details] patch disregard, typo
Tim Horton
Comment 4 2014-01-24 18:04:13 PST
Comment on attachment 222179 [details] patch nevermind, I just can't read (my own patch!)
Build Bot
Comment 5 2014-01-24 18:29:18 PST
Comment on attachment 222179 [details] patch Attachment 222179 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6269921973501952 New failing tests: platform/mac-wk2/tiled-drawing/fixed/four-bars.html platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html platform/mac-wk2/tiled-drawing/null-parent-back-crash.html dom/xhtml/level3/core/canonicalform09.xhtml platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html dom/xhtml/level3/core/canonicalform08.xhtml platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html
Build Bot
Comment 6 2014-01-24 18:29:20 PST
Created attachment 222182 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Tim Horton
Comment 7 2014-01-31 18:55:55 PST
I'll file another bug to land the WebCore part that breaks the tests; landed the WK2 null checks in http://trac.webkit.org/changeset/163230.
Note You need to log in before you can comment on or make changes to this bug.