WebKit2 View Gestures: Crash when pinch-zooming on a page that is just a frameset

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[Tim Horton]

We crash in TiledCoreAnimationDrawingArea::adjustTransientZoom, trying to play with a null shadow layer.

However, we always want a shadow layer when pinch zooming (except in Beth's new rubber banding mode, but we'll have to decide what to do about that later), so we should have one (and this will also avoid crashing).

<rdar://problem/15898349>

[Tim Horton]

Created attachment 222163 [details]
repro

[Tim Horton]

Created attachment 222179 [details]
patch

[Tim Horton]

Comment on attachment 222179 [details]
patch

disregard, typo

[Tim Horton]

Comment on attachment 222179 [details]
patch

nevermind, I just can't read (my own patch!)

[Build Bot]

Comment on attachment 222179 [details]
patch

Attachment 222179 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6269921973501952

New failing tests:
platform/mac-wk2/tiled-drawing/fixed/four-bars.html
platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset.html
platform/mac-wk2/tiled-drawing/fixed/four-bars-with-header-and-footer.html
platform/mac-wk2/tiled-drawing/clamp-out-of-bounds-scrolls.html
platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view-negative-zindex.html
platform/mac-wk2/tiled-drawing/sticky/negative-scroll-offset.html
platform/mac-wk2/tiled-drawing/fixed/negative-scroll-offset-in-view.html
platform/mac-wk2/tiled-drawing/scrolling-tree-slow-scrolling.html
platform/mac-wk2/tiled-drawing/sticky/sticky-horizontal.html
platform/mac-wk2/tiled-drawing/fixed/fixed-in-overflow.html
platform/mac-wk2/tiled-drawing/scrolling-tree-after-scroll.html
platform/mac-wk2/tiled-drawing/fixed/percentage-inside-fixed.html
platform/mac-wk2/tiled-drawing/fixed/absolute-inside-fixed.html
platform/mac-wk2/tiled-drawing/fixed/fixed-position-out-of-view.html
platform/mac-wk2/tiled-drawing/fixed/nested-fixed.html
platform/mac-wk2/tiled-drawing/null-parent-back-crash.html
dom/xhtml/level3/core/canonicalform09.xhtml
platform/mac-wk2/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.html
dom/xhtml/level3/core/canonicalform08.xhtml
platform/mac-wk2/tiled-drawing/tiled-drawing-scroll-position-page-cache-restoration.html

[Build Bot]

Created attachment 222182 [details]
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-11  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Tim Horton]

I'll file another bug to land the WebCore part that breaks the tests; landed the WK2 null checks in http://trac.webkit.org/changeset/163230.