Bug 127538

Summary: DFG should allow inlining of op_call_varargs calls
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: atrick, barraclough, ggaren, mark.lam, mhahnenberg, mmirman, msaboff, nrotem, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 127335    
Attachments:
Description Flags
getting there
none
the patch msaboff: review+

Filip Pizlo
Reported 2014-01-23 20:07:49 PST
Patch forthcoming.
Attachments
getting there (10.01 KB, patch)
2014-01-24 11:43 PST, Filip Pizlo 		no flags
DetailsFormatted DiffDiff
the patch (15.43 KB, patch)
2014-01-24 13:03 PST, Filip Pizlo 		msaboff: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-01-23 20:14:06 PST
This is freakishly weird because of how op_call_varargs gets its arguments. I think we can make it work, though. The important thing is that the ByteCodeParser needs to use the firstFreeRegister operand to decode how to lay out the call as if it was a normal call, and then to emit a sled of SetLocal's representing the arguments - again, as if this had been a normal call. Those SetLocals would be ImmediateSet. Anyway, it'l be super amazing.
Filip Pizlo
Comment 2 2014-01-24 11:43:39 PST
Created attachment 222130 [details] getting there It still has OSR exit issues but it's starting to look like something.
Filip Pizlo
Comment 3 2014-01-24 13:03:53 PST
Created attachment 222144 [details] the patch
Filip Pizlo
Comment 4 2014-01-24 16:56:20 PST
Landed in http://trac.webkit.org/changeset/162739
Note You need to log in before you can comment on or make changes to this bug.