Bug 127491

Summary: Simplify Compiler.h
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Description Darin Adler 2014-01-23 09:27:04 PST 
Simplify Compiler.h
Comment 1 Darin Adler 2014-01-23 09:38:54 PST 
Created attachment 221989 [details]
Patch
Comment 2 Darin Adler 2014-01-23 09:42:17 PST 
Forgot to mention in change log that I also removed the unused COMPILER(GCCE).
Comment 3 Darin Adler 2014-01-23 09:44:44 PST 
Created attachment 221991 [details]
Patch
Comment 4 Anders Carlsson 2014-01-23 10:08:41 PST 
Comment on attachment 221991 [details]
Patch

The OBJC_CLASS macro doesn't seem to be defined correctly.
Comment 5 Darin Adler 2014-01-23 12:23:12 PST 
Comment on attachment 221991 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221991&action=review

> Source/WTF/wtf/Compiler.h:192
> +#if !defined(OBJ_CLASS)

Oops. Typo here: “OBJ_CLASS” instead of “OBJC_CLASS”. I’ll post a new patch with that fixed first chance I get.
Comment 6 Anders Carlsson 2014-01-24 10:15:17 PST 
Comment on attachment 221991 [details]
Patch

I'm going to go ahead and land this.
Comment 7 Anders Carlsson 2014-01-24 10:16:52 PST 
Committed r162707: <http://trac.webkit.org/changeset/162707>