Bug 127491

Summary: Simplify Compiler.h
Product: WebKit Reporter: Darin Adler <darin>
Component: Web Template FrameworkAssignee: Darin Adler <darin>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, benjamin, cmarcelo, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch andersca: review+

Darin Adler
Reported 2014-01-23 09:27:04 PST
Simplify Compiler.h
Attachments
Patch (16.14 KB, patch)
2014-01-23 09:38 PST, Darin Adler 		no flags
DetailsFormatted DiffDiff
Patch (16.18 KB, patch)
2014-01-23 09:44 PST, Darin Adler 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2014-01-23 09:38:54 PST
Created attachment 221989 [details] Patch
Darin Adler
Comment 2 2014-01-23 09:42:17 PST
Forgot to mention in change log that I also removed the unused COMPILER(GCCE).
Darin Adler
Comment 3 2014-01-23 09:44:44 PST
Created attachment 221991 [details] Patch
Anders Carlsson
Comment 4 2014-01-23 10:08:41 PST
Comment on attachment 221991 [details] Patch The OBJC_CLASS macro doesn't seem to be defined correctly.
Darin Adler
Comment 5 2014-01-23 12:23:12 PST
Comment on attachment 221991 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221991&action=review > Source/WTF/wtf/Compiler.h:192 > +#if !defined(OBJ_CLASS) Oops. Typo here: “OBJ_CLASS” instead of “OBJC_CLASS”. I’ll post a new patch with that fixed first chance I get.
Anders Carlsson
Comment 6 2014-01-24 10:15:17 PST
Comment on attachment 221991 [details] Patch I'm going to go ahead and land this.
Anders Carlsson
Comment 7 2014-01-24 10:16:52 PST
Committed r162707: <http://trac.webkit.org/changeset/162707>
Note You need to log in before you can comment on or make changes to this bug.