Summary: | Add ARM EFL Linux builder bot to Apple buildmaster | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Gabor Rapcsanyi <rgabor> | ||||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | lforschler, ossy | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Attachments: |
|
Description
Gabor Rapcsanyi
2014-01-23 02:27:34 PST
Created attachment 221970 [details]
proposed patch
Comment on attachment 221970 [details] proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221970&action=review The patch looks good to me in general, but I I have some nit-picks: > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:45 > + { "name": "efl-linux-slave-4", "platform": "efl" } It would be better to have a name refer to this slave is hosted by University of Szeged. for example: szeged-slave-1 > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:189 > + "name": "EFL Linux ARMv7 Release (Build)", "type": "Build", "builddir": "efl-linux-armv7-release", Is this bot use ARM or Thumb2 instruction set? I think the name of the bot should say it: "EFL Linux ARMv7 Thumb2 Release (Build)" or "EFL Linux ARMv7 Traditional Release (Build)" (In reply to comment #2) > (From update of attachment 221970 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=221970&action=review > > The patch looks good to me in general, but I I have some nit-picks: > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:45 > > + { "name": "efl-linux-slave-4", "platform": "efl" } > > It would be better to have a name refer to this slave is hosted by University of Szeged. > for example: szeged-slave-1 > > > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:189 > > + "name": "EFL Linux ARMv7 Release (Build)", "type": "Build", "builddir": "efl-linux-armv7-release", > > Is this bot use ARM or Thumb2 instruction set? > I think the name of the bot should say it: > "EFL Linux ARMv7 Thumb2 Release (Build)" or > "EFL Linux ARMv7 Traditional Release (Build)" Sure, I can rename these. Created attachment 222433 [details]
proposed patch v2
I changed the names and added another bot. This way we can test the ARMv7 Thumb2 and Traditional instruction set on Linux.
Comment on attachment 222433 [details]
proposed patch v2
LGTM, r=me, but cq-.
Lucas, could you possibly generate passwords for the new slaves and send
them to Gábor and then land this patch and restart the master? Thanks.
Sorry for the delay, i was out of office earlier this week. I'll generate passwords and send them your way Gabor. Already fixed by https://trac.webkit.org/changeset/163101 |