Bug 127472 – Add ARM EFL Linux builder bot to Apple buildmaster

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Gabor Rapcsanyi]

Add ARM EFL Linux builder bot to Apple buildmaster

[Gabor Rapcsanyi]

Created attachment 221970 [details]
proposed patch

[Csaba Osztrogonác]

Comment on attachment 221970 [details]
proposed patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221970&action=review

The patch looks good to me in general, but I I have some nit-picks:

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:45
> +                    { "name": "efl-linux-slave-4", "platform": "efl" }

It would be better to have a name refer to this slave is hosted by University of Szeged.
for example: szeged-slave-1

> Tools/BuildSlaveSupport/build.webkit.org-config/config.json:189
> +                      "name": "EFL Linux ARMv7 Release (Build)", "type": "Build", "builddir": "efl-linux-armv7-release",

Is this bot use ARM or Thumb2 instruction set?
I think the name of the bot should say it:
"EFL Linux ARMv7 Thumb2 Release (Build)" or 
"EFL Linux ARMv7 Traditional Release (Build)"

[Gabor Rapcsanyi]

(In reply to comment #2)
> (From update of attachment 221970 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=221970&action=review
> 
> The patch looks good to me in general, but I I have some nit-picks:
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:45
> > +                    { "name": "efl-linux-slave-4", "platform": "efl" }
> 
> It would be better to have a name refer to this slave is hosted by University of Szeged.
> for example: szeged-slave-1
> 
> > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:189
> > +                      "name": "EFL Linux ARMv7 Release (Build)", "type": "Build", "builddir": "efl-linux-armv7-release",
> 
> Is this bot use ARM or Thumb2 instruction set?
> I think the name of the bot should say it:
> "EFL Linux ARMv7 Thumb2 Release (Build)" or 
> "EFL Linux ARMv7 Traditional Release (Build)"

Sure, I can rename these.

[Gabor Rapcsanyi]

Created attachment 222433 [details]
proposed patch v2

I changed the names and added another bot. This way we can test the ARMv7 Thumb2 and Traditional instruction set on Linux.

[Csaba Osztrogonác]

Comment on attachment 222433 [details]
proposed patch v2

LGTM, r=me, but cq-. 

Lucas, could you possibly generate passwords for the new slaves and send 
them to Gábor and then land this patch and restart the master? Thanks.

[Lucas Forschler]

Sorry for the delay, i was out of office earlier this week.  I'll generate passwords and send them your way Gabor.

[Csaba Osztrogonác]

Already fixed by https://trac.webkit.org/changeset/163101