Bug 127454

Summary:

WKBrowsingContextController should not be an API wrapper around WebPageProxy

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2014-01-22 16:36:04 PST

WKBrowsingContextController should not be an API wrapper around WebPageProxy

Comment 1 Anders Carlsson 2014-01-22 16:36:24 PST

Created attachment 221923 [details]
Patch

Comment 2 mitz 2014-01-22 18:18:39 PST

Comment on attachment 221923 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221923&action=review

> Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextControllerInternal.h:42
> -- (void)_finishInitialization;
>  + (NSMutableSet *)customSchemes;
>  
> +- (instancetype)_initWithPageRef:(WKPageRef)pageRef;
> ++ (WKBrowsingContextController *)_browsingContextControllerForPageRef:(WKPageRef)pageRef;

Class methods before instance methods, please.

Comment 3 Anders Carlsson 2014-01-22 18:19:39 PST

Committed r162580: <http://trac.webkit.org/changeset/162580>