Summary: | The IDB backing store get() method shouldn't call IDB callbacks directly | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||
Component: | WebCore Misc. | Assignee: | Brady Eidson <beidson> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | alecflett, bdakin, commit-queue, jsbell | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Brady Eidson
2014-01-22 16:14:05 PST
Created attachment 221919 [details]
Patch v1
Comment on attachment 221919 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=221919&action=review > Source/WebCore/ChangeLog:15 > + (WebCore::IDBServerConnectionLevelDB::get): DonĂ¢t call IDBCallbacks directly. Funny character. Attachment 221919 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
|