|Summary:||AX: Can't always increment web sliders.|
|Product:||WebKit||Reporter:||Samuel White <samuel_white>|
|Component:||Accessibility||Assignee:||Samuel White <samuel_white>|
|Severity:||Normal||CC:||aboxhall, apinheiro, cfleizach, commit-queue, dmazzoni, jcraig, jdiggs, mario, webkit-bug-importer|
|Version:||528+ (Nightly build)|
|OS:||OS X 10.9|
Description Samuel White 2014-01-22 15:34:48 PST
If a slider has no step size and a very small range, for example: min = 0, max = 10 AXIncrement and AXDecrement fail. This is because we try and increment by a percent in this case, and the percent results in a value of less than 1. Since 1 is the implicit step size in this case we need to adjust.
Comment 2 Samuel White 2014-01-22 15:42:48 PST
Created attachment 221917 [details] Initial patch for feedback. Added some basic logic to make sure we step by at least one. I'm doing this to match the keyboard behavior.
Comment 3 chris fleizach 2014-01-22 15:52:46 PST
Comment on attachment 221917 [details] Initial patch for feedback. is this the same thing that happens in the keyboard handler. do you have a layout test ready
Comment 4 Samuel White 2014-01-22 17:55:50 PST
Created attachment 221929 [details] Patch. Added layout test and updated logs.
Comment 5 Samuel White 2014-01-22 17:56:36 PST
(In reply to comment #3) > (From update of attachment 221917 [details]) > is this the same thing that happens in the keyboard handler. do you have a layout test ready Keyboard code also clamps to one in this situation. Layout test has been added.
Comment 6 WebKit Commit Bot 2014-01-22 20:08:28 PST
Comment on attachment 221929 [details] Patch. Clearing flags on attachment: 221929 Committed r162587: <http://trac.webkit.org/changeset/162587>
Comment 7 WebKit Commit Bot 2014-01-22 20:08:31 PST
All reviewed patches have been landed. Closing bug.