Bug 127443

Summary: Web Inspector: Don't include a hidden Timeline selection in the navigation path components
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch joepeck: review+, timothy: commit-queue-

Description Timothy Hatcher 2014-01-22 12:48:56 PST
When filtering happens, we don't want to keep showing the selection in the navigation bar.
Comment 1 Radar WebKit Bug Importer 2014-01-22 12:49:38 PST
<rdar://problem/15883887>
Comment 2 Timothy Hatcher 2014-01-22 12:53:49 PST
Created attachment 221895 [details]
Patch
Comment 3 Joseph Pecoraro 2014-01-22 13:10:42 PST
Comment on attachment 221895 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221895&action=review

r=me

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:47
> +        if (!previousSibling)
>              return null;

This early return can be removed, since the loop below will check if previousSibling and do the right thing.

> Source/WebInspectorUI/UserInterface/GeneralTreeElementPathComponent.js:62
> +        if (!nextSibling)
>              return null;

Ditto
Comment 4 Timothy Hatcher 2014-01-22 14:58:23 PST
https://trac.webkit.org/r162561