Summary: | Basic framework for a modern jsc CLI | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Hahnenberg <mhahnenberg> | ||||
Component: | JavaScriptCore | Assignee: | Mark Hahnenberg <mhahnenberg> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, ggaren | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | 127488 | ||||||
Bug Blocks: | 127432 | ||||||
Attachments: |
|
Description
Mark Hahnenberg
2014-01-22 11:11:51 PST
Created attachment 221896 [details]
Patch
Comment on attachment 221896 [details]
Patch
the existing jsc prompt supports multiline input which this does not appear to :(
(In reply to comment #2) > (From update of attachment 221896 [details]) > the existing jsc prompt supports multiline input which this does not appear to :( I'll file a bug for it. This will probably never replace the old jsc since other platforms can't compile Objective-C. (In reply to comment #3) > (In reply to comment #2) > > (From update of attachment 221896 [details] [details]) > > the existing jsc prompt supports multiline input which this does not appear to :( > > I'll file a bug for it. This will probably never replace the old jsc since other platforms can't compile Objective-C. I sort of skipped a sentence there. I meant to also say that this will probably not replace jsc on our own platforms for some time until the new jsc-cli reaches feature parity with the old jsc. In addition, the old jsc will probably stick around indefinitely anyways due to the absence of Objective-C on other platforms. Comment on attachment 221896 [details]
Patch
rs=me
(In reply to comment #2) > (From update of attachment 221896 [details]) > the existing jsc prompt supports multiline input which this does not appear to :( I filed bug 127484 to track this. Comment on attachment 221896 [details] Patch Clearing flags on attachment: 221896 Committed r162612: <http://trac.webkit.org/changeset/162612> All reviewed patches have been landed. Closing bug. Re-opened since this is blocked by bug 127488 Had to roll it back out because I forgot that EWS doesn't test changes to the Tools directory, and thus this patch broke several platforms. Committed r163991: <http://trac.webkit.org/changeset/163991> |