| Summary: | Refactor diff_parser | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Dániel Bátyai <dbatyai.u-szeged> | ||||||||
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | NEW --- | ||||||||||
| Severity: | Normal | CC: | ahmad.saleem792, commit-queue, eric, glenn, gsnedders, jbedard, rniwa | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Dániel Bátyai
2014-01-22 02:30:17 PST
Created attachment 221845 [details]
Proposed patch
Attachment 221845 [details] did not pass style-queue:
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:78: no spaces around keyword / parameter equals [pep8/E251] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:101: too many blank lines (2) [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:102: multiple spaces after operator [pep8/E222] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:110: missing whitespace around operator [pep8/E225] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:113: too many blank lines (2) [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:127: too many blank lines (2) [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:131: too many blank lines (2) [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:149: too many blank lines (2) [pep8/E303] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:154: missing whitespace around operator [pep8/E225] [5]
ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:160: too many blank lines (2) [pep8/E303] [5]
Total errors found: 10 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 221846 [details]
Proposed patch
Comment on attachment 221846 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221846&action=review > Tools/ChangeLog:3 > + Refactor diff_parser Although the patch looks reasonable, can you please include the addressed issues in the changelog? Created attachment 222086 [details]
Proposed patch
Added addressed issues to changlelog
Just looking quickly, it seems that we have one FIXME at least: https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Tools/Scripts/webkitpy/common/checkout/diff_parser.py#41 CCing - some people for input, whether it is good to merge this. @Sam - appreciate your input. :-) |