Bug 127419

Summary:

Refactor diff_parser

Product:

WebKit

Reporter:

Dániel Bátyai <dbatyai.u-szeged>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

CC:

ahmad.saleem792, commit-queue, eric, glenn, gsnedders, jbedard, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Proposed patch	none
Proposed patch	none
Proposed patch	none

Dániel Bátyai

Reported 2014-01-22 02:30:17 PST

Refactor diff_parser.py, and change it to compile regexes up-front instead of caching them

Attachments
Proposed patch (15.73 KB, patch) 2014-01-22 02:31 PST, Dániel Bátyai	no flags	Details Formatted Diff Diff
Proposed patch (15.75 KB, patch) 2014-01-22 02:37 PST, Dániel Bátyai	no flags	Details Formatted Diff Diff
Proposed patch (15.90 KB, patch) 2014-01-24 01:06 PST, Dániel Bátyai	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Dániel Bátyai

Comment 1 2014-01-22 02:31:25 PST

Created attachment 221845 [details] Proposed patch

WebKit Commit Bot

Comment 2 2014-01-22 02:32:36 PST

Attachment 221845 [details] did not pass style-queue: ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:78: no spaces around keyword / parameter equals [pep8/E251] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:101: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:102: multiple spaces after operator [pep8/E222] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:110: missing whitespace around operator [pep8/E225] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:113: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:127: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:131: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:149: too many blank lines (2) [pep8/E303] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:154: missing whitespace around operator [pep8/E225] [5] ERROR: Tools/Scripts/webkitpy/common/checkout/diff_parser.py:160: too many blank lines (2) [pep8/E303] [5] Total errors found: 10 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dániel Bátyai

Comment 3 2014-01-22 02:37:24 PST

Created attachment 221846 [details] Proposed patch

Zoltan Horvath

Comment 4 2014-01-22 15:21:43 PST

Comment on attachment 221846 [details] Proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=221846&action=review > Tools/ChangeLog:3 > + Refactor diff_parser Although the patch looks reasonable, can you please include the addressed issues in the changelog?

Dániel Bátyai

Comment 5 2014-01-24 01:06:05 PST

Created attachment 222086 [details] Proposed patch Added addressed issues to changlelog

Ahmad Saleem

Comment 6 2024-03-11 18:07:56 PDT

Just looking quickly, it seems that we have one FIXME at least: https://searchfox.org/wubkat/rev/711120e7edec012527620d07bf63d85713a180fd/Tools/Scripts/webkitpy/common/checkout/diff_parser.py#41 CCing - some people for input, whether it is good to merge this. @Sam - appreciate your input. :-)

Note You need to log in before you can comment on or make changes to this bug.