Bug 127398

Summary: [wk2] De-.get()ify receivers of Objective-C messages
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch none

Tim Horton
Reported 2014-01-21 20:20:07 PST
RetainPtr does the right thing when you use it as the receiver of an Obj-C message, so we don't need .get().
Attachments
patch (76.79 KB, patch)
2014-01-21 20:21 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-01-21 20:21:11 PST
Created attachment 221821 [details] patch This, because I frequently get review comments about code nearby mine that uses .get() and have to go drive-by clean it up.
Sam Weinig
Comment 2 2014-01-21 21:20:19 PST
Comment on attachment 221821 [details] patch rs=me
WebKit Commit Bot
Comment 3 2014-01-21 22:13:59 PST
Comment on attachment 221821 [details] patch Clearing flags on attachment: 221821 Committed r162505: <http://trac.webkit.org/changeset/162505>
WebKit Commit Bot
Comment 4 2014-01-21 22:14:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.