Bug 127397

Summary:

[EFL][WK2] Use std::function in the rest of EFL's WorkQueue implementation

Product:

WebKit

Reporter:

Jinwoo Song <jinwoo7.song>

Component:

WebKit EFL

Assignee:

Jinwoo Song <jinwoo7.song>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bunhere, cdumez, commit-queue, gyuyoung.kim, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Jinwoo Song

Reported 2014-01-21 19:27:28 PST

Move to using std::function and move semantics in WorkQueue::registerSocketEventHandler and DispatchQueue::setSocketEventHandler.

Attachments
Patch (5.22 KB, patch) 2014-01-21 20:52 PST, Jinwoo Song	no flags	Details Formatted Diff Diff
Patch (5.16 KB, patch) 2014-01-22 00:26 PST, Jinwoo Song	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jinwoo Song

Comment 1 2014-01-21 20:52:14 PST

Created attachment 221825 [details] Patch

WebKit Commit Bot

Comment 2 2014-01-21 20:54:34 PST

Attachment 221825 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:118: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 3 2014-01-21 21:41:03 PST

Comment on attachment 221825 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221825&action=review > Source/WebKit2/Platform/IPC/unix/ConnectionUnix.cpp:402 > + [=] { I like being explicit about what variables are captured, so I'd just use [protector] here.

Jinwoo Song

Comment 4 2014-01-22 00:26:47 PST

Created attachment 221835 [details] Patch Applied andersca's comment.

WebKit Commit Bot

Comment 5 2014-01-22 00:28:33 PST

Attachment 221835 [details] did not pass style-queue: ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.cpp:118: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.h:45: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/DispatchQueueEfl.h:70: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/efl/WorkQueueEfl.cpp:37: Extra space before ( in function call [whitespace/parens] [4] ERROR: Source/WebKit2/Platform/WorkQueue.h:69: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 5 in 6 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Commit Bot

Comment 6 2014-01-22 00:56:09 PST

Comment on attachment 221835 [details] Patch Clearing flags on attachment: 221835 Committed r162511: <http://trac.webkit.org/changeset/162511>

WebKit Commit Bot

Comment 7 2014-01-22 00:56:11 PST

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.