Bug 127393

Summary: WebKit2 View Gestures (Swipe): Swipe-start hysteresis
Product: WebKit Reporter: Tim Horton <thorton>
Component: WebKit2Assignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, bdakin, buildbot, rniwa, sam, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
patch
andersca: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 none

Tim Horton
Reported 2014-01-21 18:14:50 PST
We shouldn't start a swipe immediately upon very small scrolls in the correct direction, because we don't want to get the user trapped in a swipe. Instead, we should have some hysteresis mechanism to make sure the user really wants to swipe.
Attachments
patch (7.92 KB, patch)
2014-04-02 13:30 PDT, Tim Horton 		andersca: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 (561.61 KB, application/zip)
2014-04-02 18:31 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-01-21 18:15:30 PST
<rdar://problem/15876822>
Tim Horton
Comment 2 2014-04-02 13:30:33 PDT
Created attachment 228422 [details] patch
Build Bot
Comment 3 2014-04-02 18:31:15 PDT
Comment on attachment 228422 [details] patch Attachment 228422 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5221395600506880 New failing tests: media/W3C/audio/canPlayType/canPlayType_application_octet_stream_with_codecs_1.html
Build Bot
Comment 4 2014-04-02 18:31:17 PDT
Created attachment 228452 [details] Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-16 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Tim Horton
Comment 5 2014-04-03 13:23:31 PDT
Comment on attachment 228422 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228422&action=review > Source/WebKit2/UIProcess/mac/ViewGestureControllerMac.mm:271 > + // If a single scroll event in the sequence is "too vertical", we will stop tracking this > + // as a potential swipe until we get another "begin" event. This comment isn't quite right.
Tim Horton
Comment 6 2014-04-08 12:01:13 PDT
http://trac.webkit.org/changeset/166941
Note You need to log in before you can comment on or make changes to this bug.