Bug 127377

Summary: uint causing problems on Windows
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: cdumez, cgarcia, commit-queue, danw, dbates, gustavo, mrobinson
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Alex Christensen
Reported 2014-01-21 15:58:59 PST
There are a few places in the soup code that use uint instead of guint and it's causing problems when I'm playing with soup on Windows.
Attachments
Patch (2.36 KB, patch)
2014-01-21 16:00 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Patch (2.37 KB, patch)
2014-01-21 20:31 PST, Alex Christensen 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alex Christensen
Comment 1 2014-01-21 16:00:10 PST
Created attachment 221801 [details] Patch
Martin Robinson
Comment 2 2014-01-21 16:01:31 PST
Comment on attachment 221801 [details] Patch Probably a better choice is "unsigned int"
Alex Christensen
Comment 3 2014-01-21 20:31:36 PST
Created attachment 221823 [details] Patch
Daniel Bates
Comment 4 2014-01-21 21:57:58 PST
Comment on attachment 221823 [details] Patch This patch looks straightforward to me and is consistent with Martin Robinson's suggestion (comment 2) to explicitly use unsigned instead of the typedef guint.
WebKit Commit Bot
Comment 5 2014-01-21 22:31:46 PST
Comment on attachment 221823 [details] Patch Clearing flags on attachment: 221823 Committed r162506: <http://trac.webkit.org/changeset/162506>
WebKit Commit Bot
Comment 6 2014-01-21 22:31:49 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.