Bug 127377

Summary: uint causing problems on Windows
Product: WebKit Reporter: Alex Christensen <alex.christensen>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Trivial CC: cdumez, cgarcia, commit-queue, danw, dbates, gns, mrobinson
Priority: P5    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
Attachments:
Description Flags
Patch
none
Patch none

Description Alex Christensen 2014-01-21 15:58:59 PST
There are a few places in the soup code that use uint instead of guint and it's causing problems when I'm playing with soup on Windows.
Comment 1 Alex Christensen 2014-01-21 16:00:10 PST
Created attachment 221801 [details]
Patch
Comment 2 Martin Robinson 2014-01-21 16:01:31 PST
Comment on attachment 221801 [details]
Patch

Probably a better choice is "unsigned int"
Comment 3 Alex Christensen 2014-01-21 20:31:36 PST
Created attachment 221823 [details]
Patch
Comment 4 Daniel Bates 2014-01-21 21:57:58 PST
Comment on attachment 221823 [details]
Patch

This patch looks straightforward to me and is consistent with Martin Robinson's suggestion (comment 2) to explicitly use unsigned instead of the typedef guint.
Comment 5 WebKit Commit Bot 2014-01-21 22:31:46 PST
Comment on attachment 221823 [details]
Patch

Clearing flags on attachment: 221823

Committed r162506: <http://trac.webkit.org/changeset/162506>
Comment 6 WebKit Commit Bot 2014-01-21 22:31:49 PST
All reviewed patches have been landed.  Closing bug.