Bug 127369

Summary:

Web Inspector: Remember the Timeline Overview zoom and selection

Product:

WebKit

Reporter:

Timothy Hatcher <timothy>

Component:

Web Inspector

Assignee:

Timothy Hatcher <timothy>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
Patch	joepeck: review+, timothy: commit-queue-

Description Timothy Hatcher 2014-01-21 14:34:02 PST

We should remember the zoom level and selection window.

Comment 1 Radar WebKit Bug Importer 2014-01-21 14:34:14 PST

<rdar://problem/15874153>

Comment 2 Timothy Hatcher 2014-01-21 14:38:26 PST

Created attachment 221789 [details]
Patch

Comment 3 Timothy Hatcher 2014-01-21 14:39:32 PST

Comment on attachment 221789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221789&action=review

> Source/WebInspectorUI/UserInterface/TimelineOverview.js:61
> +    this._secondsPerPixelSetting = new WebInspector.Setting("timeline-overview-seconds-per-pixel", 0.01);

Yes, I bumped this up to 0.01 from 0.0025. This is around 12-15 seconds on a normal width. The old value was around 3 seconds and cause things to scroll quickly out of view.

Comment 4 Joseph Pecoraro 2014-01-21 14:43:28 PST

Comment on attachment 221789 [details]
Patch

r=me

Comment 5 Timothy Hatcher 2014-01-22 09:50:43 PST

https://trac.webkit.org/r162528