| Summary: | Improve the bindings of NodeList's name accessor | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||
| Component: | New Bugs | Assignee: | Benjamin Poulain <benjamin> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | cdumez, commit-queue, esprehn+autocc, ggaren, kangil.han, kondapallykalyan | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Benjamin Poulain
2014-01-21 11:35:15 PST
Created attachment 221768 [details]
Patch
Comment on attachment 221768 [details]
Patch
Is this something we can extend to all the nameGetters?
(In reply to comment #2) > (From update of attachment 221768 [details]) > Is this something we can extend to all the nameGetters? It seems indeed that several other classes suffer from the same issue. If someone can confirm this patch is correct, I'll change other objects. It may be a good idea to nuke the pair canGetItemsForName()-nameGetter() entirely. Any opinion? Comment on attachment 221768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221768&action=review r=me > Source/WebCore/bindings/js/JSNodeListCustom.cpp:57 > + slot.setValue(this, ReadOnly | DontDelete | DontEnum, toJS(exec, globalObject(), item)); I think this works. Please add a test to double-check that you haven't changed behavior of this property according to for-in enumeration and/or Object.getOwnPropertyDescriptor. Those are our best ways to test where the attributes set on the property are correct. Created attachment 222049 [details]
Patch
Comment on attachment 222049 [details]
Patch
r=me
Committed r162801: <http://trac.webkit.org/changeset/162801> |