Bug 127289 (CVE-2013-6663)

Summary: Update overlay scrollbars in single pass
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, commit-queue, jeffcz, kling, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 127354    
Bug Blocks:    
Attachments:
Description Flags
patch andersca: review+

Antti Koivisto
Reported 2014-01-20 06:07:41 PST
Multi-pass scrollbar resolution is only needed for traditional scrollbars. Overlay scrollbars don't affect layout.
Attachments
patch (4.42 KB, patch)
2014-01-20 06:36 PST, Antti Koivisto 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2014-01-20 06:36:06 PST
Created attachment 221656 [details] patch
WebKit Commit Bot
Comment 2 2014-01-20 06:38:03 PST
Attachment 221656 [details] did not pass style-queue: ERROR: Source/WebCore/platform/ScrollView.cpp:560: Should have only a single space after a punctuation in a comment. [whitespace/comments] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Antti Koivisto
Comment 3 2014-01-20 09:17:38 PST
https://trac.webkit.org/r162354
Simon Fraser (smfr)
Comment 4 2014-01-20 12:13:44 PST
Comment on attachment 221656 [details] patch I think this might be a no-op after r155660?
WebKit Commit Bot
Comment 5 2014-01-21 09:58:52 PST
Re-opened since this is blocked by bug 127354
Alexey Proskuryakov
Comment 6 2014-01-21 10:37:44 PST
Rolled out in <http://trac.webkit.org/changeset/162447>, and confirmed that this fixed the test. Looks like this is a good patch overall, but straightening its effects on accessibility seems tricky. It manifested in really weird behavior, see bug 127323.
Alexey Proskuryakov
Comment 7 2014-01-21 11:30:32 PST
> I think this might be a no-op after r155660? Definitely still not a no-op, because rolling it out changed test behavior.
Simon Fraser (smfr)
Comment 8 2014-01-21 12:24:18 PST
Yeah, I confirmed yesterday that it does eliminate calls to visibleContentsResized()
Antti Koivisto
Comment 9 2014-01-22 05:05:28 PST
Relanded in https://trac.webkit.org/r162515 It tries to resolve accessibility test flakiness by forcing layout in the test. The real bug might be in the AccessibilityController.
Note You need to log in before you can comment on or make changes to this bug.