| Summary: | AX: [ATK] Accessible names missing for imagemap images and links | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Joanmarie Diggs <jdiggs> |
| Component: | Accessibility | Assignee: | Joanmarie Diggs <jdiggs> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | buildbot, commit-queue, rniwa, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 25531 | ||
| Attachments: | |||
Created attachment 221652 [details]
test case
Created attachment 241974 [details]
Patch
(In reply to comment #3) > Created attachment 241974 [details] > Patch Turns out the alt text is there, but as the description. As per http://rawgit.com/w3c/aria/master/accname-aam/accname-aam.html#accessible-name-and-description-mapping, that's correct for the Mac (text not exposed visually) but not for ATK. I didn't bother removing it from the description for ATK. Its presence doesn't hurt anything, and there may be cases where a different description is provided and should be exposed. Comment on attachment 241974 [details] Patch Attachment 241974 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5343041212645376 New failing tests: accessibility/roles-exposed.html Created attachment 241981 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01 Port: mac-mountainlion Platform: Mac OS X 10.8.5
It seems like the failing test is failing because it is being run using the modified test, but without the modified expectations I included in the patch. (??)
FAILURE:
--- /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/accessibility/roles-exposed-expected.txt
+++ /Volumes/Data/EWS/WebKit/WebKitBuild/Release/layout-test-results/accessibility/roles-exposed-actual.txt
@@ -199,6 +199,16 @@
AXSubrole:
AXRoleDescription: image
+img[usemap][alt='X']
+ AXRole: AXImageMap
+ AXSubrole:
+ AXRoleDescription: image map
+
+img[usemap]:not([alt])
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
input[type='button']
AXRole: AXButton
AXSubrole:
@@ -319,6 +329,16 @@
AXSubrole:
AXRoleDescription:
+map
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
+area
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
mark
AXRole:
AXSubrole:
========================
diff --git a/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt b/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
index 075499890e9c97b78580d2e351ecc2c07916f471..7d321c57d5347cc820bf5cf7222423b201bfb896 100644
--- a/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
+++ b/LayoutTests/platform/mac/accessibility/roles-exposed-expected.txt
@@ -199,6 +199,16 @@ img[alt='X']
AXSubrole:
AXRoleDescription: image
+img[usemap][alt='X']
+ AXRole: AXImageMap
+ AXSubrole:
+ AXRoleDescription: image map
+
+img[usemap]:not([alt])
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
input[type='button']
AXRole: AXButton
AXSubrole:
@@ -319,6 +329,16 @@ ins
AXSubrole:
AXRoleDescription:
+map
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
+area
+ AXRole:
+ AXSubrole:
+ AXRoleDescription:
+
mark
AXRole:
AXSubrole:
Comment on attachment 241974 [details] Patch Attachment 241974 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6712059018346496 New failing tests: accessibility/roles-exposed.html Created attachment 241985 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 241988 [details]
Patch
Comment on attachment 241988 [details] Patch Attachment 241988 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5373269192474624 New failing tests: accessibility/roles-exposed.html Created attachment 241993 [details]
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 241994 [details]
Patch
Mario or Chris, got time for a review? It's another case of very little code and mostly tests (all of which now seem to pass on all versions of the Mac). Comment on attachment 241994 [details] Patch Clearing flags on attachment: 241994 Committed r176505: <http://trac.webkit.org/changeset/176505> All reviewed patches have been landed. Closing bug. |
Created attachment 221651 [details] accessible-event listener Steps to reproduce: 1. Launch the attached accessible-event listener in a terminal. 2. (Re)load the attached test case. Expected results: The tree of accessible objects printed in the terminal would have accessible names. For comparison, here's what we get from Gecko: -> [document frame | file:///home/jd/imagemap.html] -> [paragraph | ] -> [image | Planets] -> [link | Sun] -> [link | Mercury] -> [link | Venus] Actual results: Names are missing for the imagemap images and links: -> [document frame | ] -> [paragraph | ] -> [panel | ] -> [image | ] -> [link | ] -> [link | ] -> [link | ]