Bug 127275

Summary: Move HistoryItem to std::unique_ptr
Product: WebKit Reporter: Zan Dobersek <zan>
Component: New BugsAssignee: Zan Dobersek <zan>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch darin: review+

Zan Dobersek
Reported 2014-01-20 02:20:17 PST
Move HistoryItem to std::unique_ptr
Attachments
Patch (4.76 KB, patch)
2014-01-20 02:23 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (4.71 KB, patch)
2014-01-20 22:30 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (9.25 KB, patch)
2014-01-23 09:51 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (10.12 KB, patch)
2014-01-23 11:01 PST, Zan Dobersek 		no flags
DetailsFormatted DiffDiff
Patch (10.26 KB, patch)
2014-01-23 13:16 PST, Zan Dobersek 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-01-20 02:23:16 PST
Created attachment 221638 [details] Patch
Zan Dobersek
Comment 2 2014-01-20 22:30:09 PST
Created attachment 221720 [details] Patch
Brent Fulgham
Comment 3 2014-01-21 12:02:02 PST
Comment on attachment 221720 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=221720&action=review Looks good, but is missing necessary changes in Mac and Windows code. r- for these build failures. > Source/WebCore/history/HistoryItem.cpp:225 > + m_redirectURLs = nullptr; You need to make a similar change in history/mac/HistoryItemMac.mm. > Source/WebCore/history/HistoryItem.h:183 > + void setRedirectURLs(std::unique_ptr<Vector<String>>); Some Windows code (WebKit/win/WebHistoryItem.cpp) still thinks this argument is a PassOwnPtr.
Zan Dobersek
Comment 4 2014-01-23 09:51:37 PST
Created attachment 221994 [details] Patch
Zan Dobersek
Comment 5 2014-01-23 11:01:37 PST
Created attachment 222003 [details] Patch Removed the HistoryItem::setRedirectURLs symbol that's listing PassOwnPtr<Vector> as the parameter, will likely have to replace it with an updated one.
Zan Dobersek
Comment 6 2014-01-23 13:16:58 PST
Created attachment 222021 [details] Patch
Darin Adler
Comment 7 2014-01-23 16:38:58 PST
Comment on attachment 222021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222021&action=review > Source/WebKit/mac/History/WebHistoryItem.mm:391 > + std::unique_ptr<Vector<String>> redirectURLsVector = std::make_unique<Vector<String>>(size); Seems like a good place to use auto: auto redirectURLsVector = std::make_unique<Vector<String>>(size);
Zan Dobersek
Comment 8 2014-01-24 01:20:54 PST
Committed r162696: <http://trac.webkit.org/changeset/162696>
Zan Dobersek
Comment 9 2014-01-24 01:28:16 PST
Comment on attachment 222021 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=222021&action=review >> Source/WebKit/mac/History/WebHistoryItem.mm:391 >> + std::unique_ptr<Vector<String>> redirectURLsVector = std::make_unique<Vector<String>>(size); > > Seems like a good place to use auto: > > auto redirectURLsVector = std::make_unique<Vector<String>>(size); Addressed this before landing.
Note You need to log in before you can comment on or make changes to this bug.