Bug 127257

Summary: Implement ANGLE_instanced_arrays
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebGLAssignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, bunhere, cdumez, commit-queue, esprehn+autocc, gyuyoung.kim, kondapallykalyan, noam, rakuco, rniwa, roger_fong, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 126939    
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
none
Patch
none
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Patch
none
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2
none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion
none
Patch
bfulgham: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Patch
none
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion none

Description Dean Jackson 2014-01-19 13:12:34 PST
Implement instanced drawing extension.
Comment 1 Radar WebKit Bug Importer 2014-01-19 13:14:19 PST
<rdar://problem/15855212>
Comment 2 Dean Jackson 2014-01-19 13:19:03 PST
Created attachment 221596 [details]
Patch
Comment 3 Dean Jackson 2014-01-19 13:19:41 PST
Upload a patch to test build.
Comment 4 Dean Jackson 2014-01-19 13:20:25 PST
The patch isn't quite ready. It's mostly about understanding what other ports will do when they see the new gl functions. I expect they'll fail to compile.
Comment 5 WebKit Commit Bot 2014-01-19 15:40:47 PST
Attachment 221596 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1633:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1636:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1639:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1642:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1646:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:1649:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/html/canvas/WebGLRenderingContext.cpp:2029:  A case label should not be indented, but line up with its switch statement.  [whitespace/indent] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebCore/CMakeLists.txt:2668:  Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp".  [list/order] [5]
Total errors found: 11 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Build Bot 2014-01-19 16:29:10 PST
Comment on attachment 221596 [details]
Patch

Attachment 221596 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5723923182256128

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 7 Build Bot 2014-01-19 16:29:13 PST
Created attachment 221599 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 8 Build Bot 2014-01-19 16:58:52 PST
Comment on attachment 221596 [details]
Patch

Attachment 221596 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5213381493522432

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 9 Build Bot 2014-01-19 16:58:55 PST
Created attachment 221601 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 10 Build Bot 2014-01-19 17:16:29 PST
Comment on attachment 221596 [details]
Patch

Attachment 221596 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5117696265945088

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 11 Build Bot 2014-01-19 17:16:33 PST
Created attachment 221603 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 12 Dean Jackson 2014-01-20 11:33:38 PST
Created attachment 221677 [details]
Patch
Comment 13 WebKit Commit Bot 2014-01-20 11:35:21 PST
Attachment 221677 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
ERROR: Source/WebCore/CMakeLists.txt:2668:  Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp".  [list/order] [5]
Total errors found: 4 in 20 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 14 Build Bot 2014-01-20 12:20:28 PST
Comment on attachment 221677 [details]
Patch

Attachment 221677 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5956872209170432

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 15 Build Bot 2014-01-20 12:20:31 PST
Created attachment 221681 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 16 Build Bot 2014-01-20 12:51:55 PST
Comment on attachment 221677 [details]
Patch

Attachment 221677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5771939842883584

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 17 Build Bot 2014-01-20 12:51:59 PST
Created attachment 221683 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 18 Build Bot 2014-01-20 13:50:10 PST
Comment on attachment 221677 [details]
Patch

Attachment 221677 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6286037227667456

New failing tests:
fast/canvas/webgl/oes-texture-half-float.html
Comment 19 Build Bot 2014-01-20 13:50:14 PST
Created attachment 221689 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 20 Dean Jackson 2014-01-20 14:00:20 PST
Created attachment 221691 [details]
Patch
Comment 21 WebKit Commit Bot 2014-01-20 14:03:02 PST
Attachment 221691 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:2669:  Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp".  [list/order] [5]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 3 in 25 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 22 Brent Fulgham 2014-01-20 14:17:59 PST
Comment on attachment 221691 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=221691&action=review

Looks good to me, modulo the efl build error. r=me

> Source/WebCore/DerivedSources.cpp:30
> +#include "JSANGLEInstancedArrays.cpp"

Should this be protected by #if ENABLE(WEBGL)?
Comment 23 Build Bot 2014-01-20 14:59:22 PST
Comment on attachment 221691 [details]
Patch

Attachment 221691 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4620986318061568

New failing tests:
fast/canvas/webgl/angle-instanced-arrays.html
Comment 24 Build Bot 2014-01-20 14:59:26 PST
Created attachment 221694 [details]
Archive of layout-test-results from webkit-ews-16 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-16  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 25 Build Bot 2014-01-20 15:23:20 PST
Comment on attachment 221691 [details]
Patch

Attachment 221691 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6439109862096896

New failing tests:
fast/canvas/webgl/angle-instanced-arrays.html
Comment 26 Build Bot 2014-01-20 15:23:25 PST
Created attachment 221698 [details]
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-03  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 27 Build Bot 2014-01-20 16:27:46 PST
Comment on attachment 221691 [details]
Patch

Attachment 221691 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6146376366817280

New failing tests:
fast/canvas/webgl/angle-instanced-arrays.html
Comment 28 Build Bot 2014-01-20 16:27:50 PST
Created attachment 221703 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 29 Dean Jackson 2014-01-22 13:32:17 PST
Created attachment 221899 [details]
Patch
Comment 30 Dean Jackson 2014-01-22 13:33:31 PST
Incorporated Brent's review comment. Trying to see if I can get it to compile before landing.

Not sure why the new test failed on mac :(
Comment 31 WebKit Commit Bot 2014-01-22 13:34:51 PST
Attachment 221899 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:2669:  Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp".  [list/order] [5]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 7 in 26 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 32 Build Bot 2014-01-22 14:26:46 PST
Comment on attachment 221899 [details]
Patch

Attachment 221899 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5804113644224512

New failing tests:
fast/canvas/webgl/angle-instanced-arrays.html
Comment 33 Build Bot 2014-01-22 14:26:49 PST
Created attachment 221904 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 34 Dean Jackson 2014-01-22 14:48:04 PST
Created attachment 221907 [details]
Patch
Comment 35 Dean Jackson 2014-01-22 14:49:31 PST
I think I worked it out. Mountain Lion needs specific results. No need for review.
Comment 36 WebKit Commit Bot 2014-01-22 14:50:36 PST
Attachment 221907 [details] did not pass style-queue:


ERROR: Source/WebCore/CMakeLists.txt:2669:  Alphabetical sorting problem. "platform/text/TextCodecICU.cpp" should be before "platform/text/icu/UTextProviderUTF16.cpp".  [list/order] [5]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 12)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:355:  Wrong number of spaces before statement. (expected: 8)  [whitespace/indent] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:428:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/platform/graphics/GraphicsContext3D.h:429:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 7 in 27 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 37 Build Bot 2014-01-22 15:00:34 PST
Comment on attachment 221899 [details]
Patch

Attachment 221899 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6093500286238720

New failing tests:
fast/canvas/webgl/angle-instanced-arrays.html
Comment 38 Build Bot 2014-01-22 15:00:42 PST
Created attachment 221910 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 39 Dean Jackson 2014-01-22 15:45:14 PST
Committed r162565: <http://trac.webkit.org/changeset/162565>